Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py

Issue 2128403002: Remove constant ALL_BASELINE_VARIANTS from port/test.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py
index dfaa69e5c2c659f596c448ad6db9cbe343572316..39d235bbfdc7b6c5de9992c43685dc54361cacc8 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py
@@ -41,7 +41,11 @@ class PrintExpectationsTest(unittest.TestCase):
options = MockOptions(all=False, csv=False, full=False, platform=platform,
include_keyword=[], exclude_keyword=[], paths=False).update(**args)
tool = MockTool()
- tool.port_factory.all_port_names = lambda: TestPort.ALL_BASELINE_VARIANTS
+ tool.port_factory.all_port_names = lambda: [
+ 'test-linux-trusty', 'test-linux-precise',
+ 'test-mac-mac10.11', 'test-mac-mac10.10',
+ 'test-win-win10', 'test-win-win7'
+ ]
command = PrintExpectations()
command.bind_to_tool(tool)
@@ -111,7 +115,11 @@ class PrintBaselinesTest(unittest.TestCase):
self.tool = MockTool()
self.test_port = self.tool.port_factory.get('test-win-win7')
self.tool.port_factory.get = lambda port_name=None: self.test_port
- self.tool.port_factory.all_port_names = lambda: TestPort.ALL_BASELINE_VARIANTS
+ self.tool.port_factory.all_port_names = lambda: [
+ 'test-linux-trusty', 'test-linux-precise',
+ 'test-mac-mac10.11', 'test-mac-mac10.10',
+ 'test-win-win10', 'test-win-win7'
+ ]
def tearDown(self):
if self.oc:
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698