Check in codegen test expectations.

Check in codegen test expectations.

Codegen output is checked into repository to make codegen regressions
more visible (especially readability regressions).

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/85f7ddfdf7bed2df8233360011beaf8b98ac7fb7

[Leaf, 2016-07-07 20:09:53]

leafp@google.com changed reviewers:
+ rnystrom@google.com

[Leaf, 2016-07-07 20:10:18]

Code changes are all in test/codegen_test.dart.  The rest are just the .js
output files from gen/ that are now also copied into test/expect which is
checked into git.

[Bob Nystrom, 2016-07-07 21:48:53]

Two questions/suggestions:

1. How do you feel about a different name for the directory than "expect"? It's
a bit confusing because there is also an expect package and library, and even
more confusingly, I think there is an expectation file for the expect library.

2. If I recall, this places the expectations in a subdirectory of the files they
are compiled from. I always found that a little strange. What do you think of
hoisting "expect" up to be a sibling of the directory that contains the
compilation sources?

Either way, LGTM!

[Leaf, 2016-07-07 22:57:27]

Description was changed from

==========
Check in codegen test expectations.

Codegen output is checked into repository to make codegen regressions
more visible (especially readability regressions).

BUG=
==========

to

==========
Check in codegen test expectations.

Codegen output is checked into repository to make codegen regressions
more visible (especially readability regressions).

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/85f7ddfdf7bed2df8233360011be...
==========

[Leaf, 2016-07-07 22:57:40]

Committed patchset #1 (id:1) manually as
85f7ddfdf7bed2df8233360011beaf8b98ac7fb7 (presubmit successful).