Ntp, darken the color of the overScroll for the RecyclerView

Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly too light, darken this so users can see when reaching the bottom of the page. Add a 32dp at the bottom of the RecyclerView.

videos: https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ

BUG=603851
Committed: https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c
Cr-Commit-Position: refs/heads/master@{#404364}

[mcwilliams, 2016-07-07 11:01:52]

Description was changed from

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.

BUG=603851
==========

to

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.

BUG=603851
==========

[mcwilliams, 2016-07-07 13:21:12]

Description was changed from

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.

BUG=603851
==========

to

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.
Add a 32dp at the bottom of the RecyclerView.

videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ

BUG=603851
==========

[mcwilliams, 2016-07-07 13:23:10]

mcwilliams@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-07-07 13:45:44]

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
chrome/android/java/res/values-v17/styles.xml:557: <style
name="NewTabPageRecyclerView">
What happens pre-JB-MR1, when this style isn't defined?

[PEConn, 2016-07-07 14:01:14]

peconn@chromium.org changed reviewers:
+ peconn@chromium.org

[PEConn, 2016-07-07 14:01:15]

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
File chrome/android/java/res/layout/new_tab_page_recycler_view.xml (right):

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
chrome/android/java/res/layout/new_tab_page_recycler_view.xml:15:
android:theme="@style/NewTabPageRecyclerView" />
I'm still not fully clear on the difference between 'style' and 'android:theme'
- I'm just getting references to themes being universal - is there any way this
may effect the shadows for anything other than the RecyclerView?

Are there any other shadows visible when the RecyclerView is loaded? It may be
worth checking if there are any shadows in the omnibox suggestions list when you
scroll on it.

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
chrome/android/java/res/values-v17/styles.xml:557: <style
name="NewTabPageRecyclerView">
On 2016/07/07 13:45:44, Bernhard Bauer wrote:
> What happens pre-JB-MR1, when this style isn't defined?

There's a comment at the top of the file about how we use values-v17. I think
all the entries in here are automatically generated for v14 as well - though
I've never tested it myself.

[Bernhard Bauer, 2016-07-07 14:11:18]

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
chrome/android/java/res/values-v17/styles.xml:557: <style
name="NewTabPageRecyclerView">
On 2016/07/07 14:01:15, PEConn1 wrote:
> On 2016/07/07 13:45:44, Bernhard Bauer wrote:
> > What happens pre-JB-MR1, when this style isn't defined?
> 
> There's a comment at the top of the file about how we use values-v17. I think
> all the entries in here are automatically generated for v14 as well - though
> I've never tested it myself.

OK... colorEdgeEffect is only defined from API level 21 on though, so we should
probably put that into values-v21, and have a fallback here.

[mcwilliams, 2016-07-08 08:29:30]

PTAL

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
File chrome/android/java/res/layout/new_tab_page_recycler_view.xml (right):

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
chrome/android/java/res/layout/new_tab_page_recycler_view.xml:15:
android:theme="@style/NewTabPageRecyclerView" />
On 2016/07/07 14:01:15, PEConn1 wrote:
> I'm still not fully clear on the difference between 'style' and
'android:theme'
> - I'm just getting references to themes being universal - is there any way
this
> may effect the shadows for anything other than the RecyclerView?
> 
> Are there any other shadows visible when the RecyclerView is loaded? It may be
> worth checking if there are any shadows in the omnibox suggestions list when
you
> scroll on it.

All seems to behave correctly - I cannot find specific documentation on the
difference

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
chrome/android/java/res/values-v17/styles.xml:557: <style
name="NewTabPageRecyclerView">
On 2016/07/07 14:11:18, Bernhard Bauer wrote:
> On 2016/07/07 14:01:15, PEConn1 wrote:
> > On 2016/07/07 13:45:44, Bernhard Bauer wrote:
> > > What happens pre-JB-MR1, when this style isn't defined?
> > 
> > There's a comment at the top of the file about how we use values-v17. I
think
> > all the entries in here are automatically generated for v14 as well - though
> > I've never tested it myself.
> 
> OK... colorEdgeEffect is only defined from API level 21 on though, so we
should
> probably put that into values-v21, and have a fallback here.

Tested on kitkat and has little to no effect:
https://drive.google.com/open?id=0B1IgAIJ9cgizSXd1YXNaM2ppQmM

[Bernhard Bauer, 2016-07-08 09:52:51]

On 2016/07/08 08:29:30, mcwilliams wrote:
> PTAL
> 
>
https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
> File chrome/android/java/res/layout/new_tab_page_recycler_view.xml (right):
> 
>
https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
> chrome/android/java/res/layout/new_tab_page_recycler_view.xml:15:
> android:theme="@style/NewTabPageRecyclerView" />
> On 2016/07/07 14:01:15, PEConn1 wrote:
> > I'm still not fully clear on the difference between 'style' and
> 'android:theme'
> > - I'm just getting references to themes being universal - is there any way
> this
> > may effect the shadows for anything other than the RecyclerView?
> > 
> > Are there any other shadows visible when the RecyclerView is loaded? It may
be
> > worth checking if there are any shadows in the omnibox suggestions list when
> you
> > scroll on it.
> 
> All seems to behave correctly - I cannot find specific documentation on the
> difference
> 
>
https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
> File chrome/android/java/res/values-v17/styles.xml (right):
> 
>
https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/re...
> chrome/android/java/res/values-v17/styles.xml:557: <style
> name="NewTabPageRecyclerView">
> On 2016/07/07 14:11:18, Bernhard Bauer wrote:
> > On 2016/07/07 14:01:15, PEConn1 wrote:
> > > On 2016/07/07 13:45:44, Bernhard Bauer wrote:
> > > > What happens pre-JB-MR1, when this style isn't defined?
> > > 
> > > There's a comment at the top of the file about how we use values-v17. I
> think
> > > all the entries in here are automatically generated for v14 as well -
though
> > > I've never tested it myself.
> > 
> > OK... colorEdgeEffect is only defined from API level 21 on though, so we
> should
> > probably put that into values-v21, and have a fallback here.
> 
> Tested on kitkat and has little to no effect:
> https://drive.google.com/open?id=0B1IgAIJ9cgizSXd1YXNaM2ppQmM

Could you also check that there is no lint warning about it? Currently it would
be somewhere inside the gigantic pile of existing warnings, but I would rather
we reduce those, not add to them.

[mcwilliams, 2016-07-08 10:32:35]

No lint errors that I can see and went through the full stack

[Bernhard Bauer, 2016-07-08 10:41:04]

Thanks for checking! LGTM

[mcwilliams, 2016-07-08 11:43:44]

The CQ bit was checked by mcwilliams@chromium.org

[commit-bot: I haz the power, 2016-07-08 11:44:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 14:17:26]

Description was changed from

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.
Add a 32dp at the bottom of the RecyclerView.

videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ

BUG=603851
==========

to

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.
Add a 32dp at the bottom of the RecyclerView.

videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ

BUG=603851
==========

[commit-bot: I haz the power, 2016-07-08 14:17:27]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-08 14:17:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 14:19:48]

Description was changed from

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.
Add a 32dp at the bottom of the RecyclerView.

videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ

BUG=603851
==========

to

==========
Ntp, darken the color of the overScroll for the RecyclerView

The background is currently grey so the overScroll colorEdgeEffect to a slightly
too light, darken this so users can see when reaching the bottom of the page.
Add a 32dp at the bottom of the RecyclerView.

videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ

BUG=603851

Committed: https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c
Cr-Commit-Position: refs/heads/master@{#404364}
==========

[commit-bot: I haz the power, 2016-07-08 14:19:49]

Patchset 6 (id:??) landed as
https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c
Cr-Commit-Position: refs/heads/master@{#404364}