Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2127083002: Ntp, darken the color of the overScroll for the RecyclerView (Closed)

Created:
4 years, 5 months ago by mcwilliams
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer, PEConn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp, darken the color of the overScroll for the RecyclerView The background is currently grey so the overScroll colorEdgeEffect to a slightly too light, darken this so users can see when reaching the bottom of the page. Add a 32dp at the bottom of the RecyclerView. videos: https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ BUG=603851 Committed: https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c Cr-Commit-Position: refs/heads/master@{#404364}

Patch Set 1 #

Patch Set 2 : changes #

Patch Set 3 : Changes #

Patch Set 4 : Changes #

Patch Set 5 : Changes #

Patch Set 6 : changes #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/android/java/res/layout/new_tab_page_recycler_view.xml View 1 2 3 5 1 chunk +2 lines, -1 line 2 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 2 3 1 chunk +4 lines, -0 lines 4 comments Download
M chrome/android/java/res/values/dimens.xml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 1 2 3 4 5 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
mcwilliams
4 years, 5 months ago (2016-07-07 13:23:11 UTC) #4
Bernhard Bauer
https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/values-v17/styles.xml File chrome/android/java/res/values-v17/styles.xml (right): https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/values-v17/styles.xml#newcode557 chrome/android/java/res/values-v17/styles.xml:557: <style name="NewTabPageRecyclerView"> What happens pre-JB-MR1, when this style isn't ...
4 years, 5 months ago (2016-07-07 13:45:44 UTC) #5
PEConn
https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/layout/new_tab_page_recycler_view.xml File chrome/android/java/res/layout/new_tab_page_recycler_view.xml (right): https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/layout/new_tab_page_recycler_view.xml#newcode15 chrome/android/java/res/layout/new_tab_page_recycler_view.xml:15: android:theme="@style/NewTabPageRecyclerView" /> I'm still not fully clear on the ...
4 years, 5 months ago (2016-07-07 14:01:15 UTC) #7
Bernhard Bauer
https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/values-v17/styles.xml File chrome/android/java/res/values-v17/styles.xml (right): https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/values-v17/styles.xml#newcode557 chrome/android/java/res/values-v17/styles.xml:557: <style name="NewTabPageRecyclerView"> On 2016/07/07 14:01:15, PEConn1 wrote: > On ...
4 years, 5 months ago (2016-07-07 14:11:18 UTC) #8
mcwilliams
PTAL https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/layout/new_tab_page_recycler_view.xml File chrome/android/java/res/layout/new_tab_page_recycler_view.xml (right): https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/layout/new_tab_page_recycler_view.xml#newcode15 chrome/android/java/res/layout/new_tab_page_recycler_view.xml:15: android:theme="@style/NewTabPageRecyclerView" /> On 2016/07/07 14:01:15, PEConn1 wrote: > ...
4 years, 5 months ago (2016-07-08 08:29:30 UTC) #9
Bernhard Bauer
On 2016/07/08 08:29:30, mcwilliams wrote: > PTAL > > https://codereview.chromium.org/2127083002/diff/100001/chrome/android/java/res/layout/new_tab_page_recycler_view.xml > File chrome/android/java/res/layout/new_tab_page_recycler_view.xml (right): > ...
4 years, 5 months ago (2016-07-08 09:52:51 UTC) #10
mcwilliams
No lint errors that I can see and went through the full stack
4 years, 5 months ago (2016-07-08 10:32:35 UTC) #11
Bernhard Bauer
Thanks for checking! LGTM
4 years, 5 months ago (2016-07-08 10:41:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127083002/100001
4 years, 5 months ago (2016-07-08 11:44:29 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-08 14:17:27 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:17:32 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:19:49 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c
Cr-Commit-Position: refs/heads/master@{#404364}

Powered by Google App Engine
This is Rietveld 408576698