chrome/android/java/res/layout/new_tab_page_recycler_view.xml - Issue 2127083002: Ntp, darken the color of the overScroll for the RecyclerView

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_recycler_view.xml

Issue 2127083002: Ntp, darken the color of the overScroll for the RecyclerView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/res/values-v17/styles.xml » ('J')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView	6 <org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 android:background="@color/ntp_material_design_bg"	8 android:background="@color/ntp_material_design_bg"

9 android:fillViewport="true"	9 android:fillViewport="true"

10 android:layout_width="match_parent"	10 android:layout_width="match_parent"

11 android:layout_height="match_parent"	11 android:layout_height="match_parent"

12 android:focusable="true"	12 android:focusable="true"

13 android:focusableInTouchMode="true"	13 android:focusableInTouchMode="true"

14 android:contentDescription="@string/accessibility_new_tab_page" />	14 android:contentDescription="@string/accessibility_new_tab_page"

	15 android:theme="@style/NewTabPageRecyclerView" />
	PEConn 2016/07/07 14:01:15 I'm still not fully clear on the difference betwee I'm still not fully clear on the difference between 'style' and 'android:theme' - I'm just getting references to themes being universal - is there any way this may effect the shadows for anything other than the RecyclerView? Are there any other shadows visible when the RecyclerView is loaded? It may be worth checking if there are any shadows in the omnibox suggestions list when you scroll on it. mcwilliams 2016/07/08 08:29:30 All seems to behave correctly - I cannot find spec Show quoted text On 2016/07/07 14:01:15, PEConn1 wrote: > I'm still not fully clear on the difference between 'style' and 'android:theme' > - I'm just getting references to themes being universal - is there any way this > may effect the shadows for anything other than the RecyclerView? > > Are there any other shadows visible when the RecyclerView is loaded? It may be > worth checking if there are any shadows in the omnibox suggestions list when you > scroll on it. All seems to behave correctly - I cannot find specific documentation on the difference
OLD	NEW