Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2127083002: Ntp, darken the color of the overScroll for the RecyclerView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/values-v17/styles.xml
diff --git a/chrome/android/java/res/values-v17/styles.xml b/chrome/android/java/res/values-v17/styles.xml
index cd643ac1376554aac152ee4ede54bc0a3e1f7bbd..76fda39b1e97d8530450b3a6b23f838981ba5467 100644
--- a/chrome/android/java/res/values-v17/styles.xml
+++ b/chrome/android/java/res/values-v17/styles.xml
@@ -553,4 +553,8 @@
<item name="android:paddingEnd">16dp</item>
<item name="android:background">?attr/listChoiceBackgroundIndicator</item>
</style>
+ <!-- New tab page RecyclerView overscroll color -->
+ <style name="NewTabPageRecyclerView">
Bernhard Bauer 2016/07/07 13:45:44 What happens pre-JB-MR1, when this style isn't def
PEConn 2016/07/07 14:01:15 There's a comment at the top of the file about how
Bernhard Bauer 2016/07/07 14:11:18 OK... colorEdgeEffect is only defined from API lev
mcwilliams 2016/07/08 08:29:30 Tested on kitkat and has little to no effect: http
+ <item name="android:colorEdgeEffect">@color/google_grey_300</item>
+ </style>
</resources>

Powered by Google App Engine
This is Rietveld 408576698