chrome/android/java/res/values-v17/styles.xml - Issue 2127083002: Ntp, darken the color of the overScroll for the RecyclerView

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2127083002: Ntp, darken the color of the overScroll for the RecyclerView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/new_tab_page_recycler_view.xml ('K') | « chrome/android/java/res/layout/new_tab_page_recycler_view.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources xmlns:tools="http://schemas.android.com/tools">	6 <resources xmlns:tools="http://schemas.android.com/tools">

7 <!-- Q: Why put style resources under values-v17/ ?	7 <!-- Q: Why put style resources under values-v17/ ?

8 A: Problem:	8 A: Problem:

9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.	9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.

10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert	10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert

(...skipping 535 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
546 </style>	546 </style>

547 <style name="ToolbarMenuButtonTablet" parent="ToolbarButton">	547 <style name="ToolbarMenuButtonTablet" parent="ToolbarButton">

548 <item name="android:layout_width">43dp</item>	548 <item name="android:layout_width">43dp</item>

549 <item name="android:paddingEnd">3.5dp</item>	549 <item name="android:paddingEnd">3.5dp</item>

550 </style>	550 </style>

551 <style name="AppMenuItem">	551 <style name="AppMenuItem">

552 <item name="android:paddingStart">16dp</item>	552 <item name="android:paddingStart">16dp</item>

553 <item name="android:paddingEnd">16dp</item>	553 <item name="android:paddingEnd">16dp</item>

554 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>	554 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>

555 </style>	555 </style>

	556 <!-- New tab page RecyclerView overscroll color -->

	557 <style name="NewTabPageRecyclerView">
	Bernhard Bauer 2016/07/07 13:45:44 What happens pre-JB-MR1, when this style isn't def What happens pre-JB-MR1, when this style isn't defined? PEConn 2016/07/07 14:01:15 There's a comment at the top of the file about how Show quoted text On 2016/07/07 13:45:44, Bernhard Bauer wrote: > What happens pre-JB-MR1, when this style isn't defined? There's a comment at the top of the file about how we use values-v17. I think all the entries in here are automatically generated for v14 as well - though I've never tested it myself. Bernhard Bauer 2016/07/07 14:11:18 OK... colorEdgeEffect is only defined from API lev Show quoted text On 2016/07/07 14:01:15, PEConn1 wrote: > On 2016/07/07 13:45:44, Bernhard Bauer wrote: > > What happens pre-JB-MR1, when this style isn't defined? > > There's a comment at the top of the file about how we use values-v17. I think > all the entries in here are automatically generated for v14 as well - though > I've never tested it myself. OK... colorEdgeEffect is only defined from API level 21 on though, so we should probably put that into values-v21, and have a fallback here. mcwilliams 2016/07/08 08:29:30 Tested on kitkat and has little to no effect: http Show quoted text On 2016/07/07 14:11:18, Bernhard Bauer wrote: > On 2016/07/07 14:01:15, PEConn1 wrote: > > On 2016/07/07 13:45:44, Bernhard Bauer wrote: > > > What happens pre-JB-MR1, when this style isn't defined? > > > > There's a comment at the top of the file about how we use values-v17. I think > > all the entries in here are automatically generated for v14 as well - though > > I've never tested it myself. > > OK... colorEdgeEffect is only defined from API level 21 on though, so we should > probably put that into values-v21, and have a fallback here. Tested on kitkat and has little to no effect: https://drive.google.com/open?id=0B1IgAIJ9cgizSXd1YXNaM2ppQmM
	558 <item name="android:colorEdgeEffect">@color/google_grey_300</item>

	559 </style>

556 </resources>	560 </resources>

OLD	NEW