SELECT element: Improve performance of HTMLSelectElement::optionIndexToBeShown().

SELECT element: Improve performance of HTMLSelectElement::optionIndexToBeShown().

It was usually O(N).  This CL makes it O(1) by changing the return value from
index to HTMLOptionElement*, and renames it to optionToBeShown().

Also,
 - Change the argument type of LayoutMenuList::didSetSelectionIndex and
   didUpdateActiveOption; index -> HTMLOptionElement*.
 - Rename didSetSelectionIndex to didSelectOption.
 - Merge LayoutMenuList::setTextFromOption into updateFromElement.

BUG=577989
Committed: https://crrev.com/c9df91f8cc501a4a952eb08877c3c3e6b2ca01bb
Cr-Commit-Position: refs/heads/master@{#404157}

[tkent, 2016-07-07 07:16:05]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-07-07 07:16:06]

Keishi, would you review this please?

[keishi, 2016-07-07 08:16:05]

LGTM

[tkent, 2016-07-07 14:22:45]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-07-07 14:23:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 16:23:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-07 16:25:19]

Description was changed from

==========
SELECT element: Improve performance of
HTMLSelectElement::optionIndexToBeShown().

It was usually O(N).  This CL makes it O(1) by changing the return value from
index to HTMLOptionElement*, and renames it to optionToBeShown().

Also,
 - Change the argument type of LayoutMenuList::didSetSelectionIndex and
   didUpdateActiveOption; index -> HTMLOptionElement*.
 - Rename didSetSelectionIndex to didSelectOption.
 - Merge LayoutMenuList::setTextFromOption into updateFromElement.

BUG=577989
==========

to

==========
SELECT element: Improve performance of
HTMLSelectElement::optionIndexToBeShown().

It was usually O(N).  This CL makes it O(1) by changing the return value from
index to HTMLOptionElement*, and renames it to optionToBeShown().

Also,
 - Change the argument type of LayoutMenuList::didSetSelectionIndex and
   didUpdateActiveOption; index -> HTMLOptionElement*.
 - Rename didSetSelectionIndex to didSelectOption.
 - Merge LayoutMenuList::setTextFromOption into updateFromElement.

BUG=577989

Committed: https://crrev.com/c9df91f8cc501a4a952eb08877c3c3e6b2ca01bb
Cr-Commit-Position: refs/heads/master@{#404157}
==========

[commit-bot: I haz the power, 2016-07-07 16:25:20]

Patchset 1 (id:??) landed as
https://crrev.com/c9df91f8cc501a4a952eb08877c3c3e6b2ca01bb
Cr-Commit-Position: refs/heads/master@{#404157}