third_party/WebKit/Source/core/html/HTMLSelectElement.h - Issue 2126023005: SELECT element: Improve performance of HTMLSelectElement::optionIndexToBeShown().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2126023005: SELECT element: Improve performance of HTMLSelectElement::optionIndexToBeShown(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

index cdc4fe9a9b0a5d5e6fc00a471a4ffcb639bdd1fb..48d88ca74e71f59e079c62e4a6ff1541b2c886a9 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

@@ -150,7 +150,7 @@ public:

void provisionalSelectionChanged(unsigned);

void popupDidHide();

bool popupIsVisible() const { return m_popupIsVisible; }

- int optionIndexToBeShown() const;

+ HTMLOptionElement* optionToBeShown() const;

void showPopup();

void hidePopup();

PopupMenu* popup() const { return m_popup.get(); }

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »