Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2126023005: SELECT element: Improve performance of HTMLSelectElement::optionIndexToBeShown(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 LayoutUnit clientPaddingLeft() const; 143 LayoutUnit clientPaddingLeft() const;
144 // Text starting offset in RTL. 144 // Text starting offset in RTL.
145 LayoutUnit clientPaddingRight() const; 145 LayoutUnit clientPaddingRight() const;
146 void valueChanged(unsigned listIndex); 146 void valueChanged(unsigned listIndex);
147 // A popup is canceled when the popup was hidden without selecting an item. 147 // A popup is canceled when the popup was hidden without selecting an item.
148 void popupDidCancel(); 148 void popupDidCancel();
149 // Provisional selection is a selection made using arrow keys or type ahead. 149 // Provisional selection is a selection made using arrow keys or type ahead.
150 void provisionalSelectionChanged(unsigned); 150 void provisionalSelectionChanged(unsigned);
151 void popupDidHide(); 151 void popupDidHide();
152 bool popupIsVisible() const { return m_popupIsVisible; } 152 bool popupIsVisible() const { return m_popupIsVisible; }
153 int optionIndexToBeShown() const; 153 HTMLOptionElement* optionToBeShown() const;
154 void showPopup(); 154 void showPopup();
155 void hidePopup(); 155 void hidePopup();
156 PopupMenu* popup() const { return m_popup.get(); } 156 PopupMenu* popup() const { return m_popup.get(); }
157 void didMutateSubtree(); 157 void didMutateSubtree();
158 158
159 void resetTypeAheadSessionForTesting(); 159 void resetTypeAheadSessionForTesting();
160 160
161 DECLARE_VIRTUAL_TRACE(); 161 DECLARE_VIRTUAL_TRACE();
162 162
163 protected: 163 protected:
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 287
288 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption); 288 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption);
289 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption); 289 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption);
290 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption); 290 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption);
291 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption); 291 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption);
292 }; 292 };
293 293
294 } // namespace blink 294 } // namespace blink
295 295
296 #endif // HTMLSelectElement_h 296 #endif // HTMLSelectElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698