third_party/WebKit/Source/core/layout/LayoutMenuList.h - Issue 2126023005: SELECT element: Improve performance of HTMLSelectElement::optionIndexToBeShown().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMenuList.h

Issue 2126023005: SELECT element: Improve performance of HTMLSelectElement::optionIndexToBeShown(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMenuList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMenuList.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMenuList.h b/third_party/WebKit/Source/core/layout/LayoutMenuList.h

index fa96089fe3803bd0066118401a782f75e88782cd..743f94c104cac6f933f34b6f401be365a62ecf39 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMenuList.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMenuList.h

@@ -39,7 +39,7 @@ public:

~LayoutMenuList() override;

HTMLSelectElement* selectElement() const;

- void didSetSelectedIndex(int optionIndex);

+ void didSelectOption(HTMLOptionElement*);

String text() const;

const char* name() const override { return "LayoutMenuList"; }

@@ -79,13 +79,12 @@ private:

void createInnerBlock();

void adjustInnerStyle();

void setText(const String&);

- void setTextFromOption(int optionIndex);

void updateInnerBlockHeight();

void updateOptionsWidth() const;

float computeTextWidth(const TextRun&, const ComputedStyle&) const;

void setIndexToSelectOnCancel(int listIndex);

- void didUpdateActiveOption(int optionIndex);

+ void didUpdateActiveOption(HTMLOptionElement*);

LayoutText* m_buttonText;

LayoutBlock* m_innerBlock;