Mac: Clean up visibility state tracking

Mac: Clean up visibility state tracking

Trying to fix this has been a source of hung frames.

This makes the DelegatedFrameHostClient's IsVisible callback return
the variable that tracks whether or not the DelegatedFrameHost's owner
has set it to be visible.

BUG=623716
Committed: https://crrev.com/4309d664520802fe54ba603622b1222741e427aa
Cr-Commit-Position: refs/heads/master@{#404469}

[ccameron, 2016-07-06 23:31:38]

Description was changed from

==========
Mac: Clean up visibility state tracking

Trying to fix this has been a source of hung frames.

This makes the DelegatedFrameHostClient's IsVisible callback return
the variable that tracks whether or not the DelegatedFrameHost's owner
has set it to be visible.

BUG=
==========

to

==========
Mac: Clean up visibility state tracking

Trying to fix this has been a source of hung frames.

This makes the DelegatedFrameHostClient's IsVisible callback return
the variable that tracks whether or not the DelegatedFrameHost's owner
has set it to be visible.

BUG=623716
==========

[ccameron, 2016-07-06 23:31:38]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2016-07-06 23:33:42]

I think, with this in, this is in a state that I don't mind leaving it for a
bit.

The ui::AcceleratedWidgetMac client interface is a bit odd, but it's tied to the
VSync stuff, so that will need to be cleaned up first.

[enne (OOO), 2016-07-07 00:11:40]

I'm not sure I follow what all the implications of this are.  Can the RWH and
browser compositor attached state be out of sync after this?  Is that only
possible during thumbnailing?

[ccameron, 2016-07-08 18:09:33]

On 2016/07/07 00:11:40, enne wrote:
> I'm not sure I follow what all the implications of this are.  Can the RWH and
> browser compositor attached state be out of sync after this?  Is that only
> possible during thumbnailing?

I suspect that they are correctly in sync (that is to say, RWHImpl visible
implies DFH visible)

My guess is that the bugs that we saw were due to the DFHClient's IsVisible
method returning RWHImpl visible instead of DFH visible.

[enne (OOO), 2016-07-08 18:29:12]

Ok, lgtm.  If this turns out to have bugs, they'll turn up and this is small
enough to be reverted if so.

[ccameron, 2016-07-08 18:44:04]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-07-08 18:44:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 19:51:16]

Description was changed from

==========
Mac: Clean up visibility state tracking

Trying to fix this has been a source of hung frames.

This makes the DelegatedFrameHostClient's IsVisible callback return
the variable that tracks whether or not the DelegatedFrameHost's owner
has set it to be visible.

BUG=623716
==========

to

==========
Mac: Clean up visibility state tracking

Trying to fix this has been a source of hung frames.

This makes the DelegatedFrameHostClient's IsVisible callback return
the variable that tracks whether or not the DelegatedFrameHost's owner
has set it to be visible.

BUG=623716
==========

[commit-bot: I haz the power, 2016-07-08 19:51:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 19:52:23]

Description was changed from

==========
Mac: Clean up visibility state tracking

Trying to fix this has been a source of hung frames.

This makes the DelegatedFrameHostClient's IsVisible callback return
the variable that tracks whether or not the DelegatedFrameHost's owner
has set it to be visible.

BUG=623716
==========

to

==========
Mac: Clean up visibility state tracking

Trying to fix this has been a source of hung frames.

This makes the DelegatedFrameHostClient's IsVisible callback return
the variable that tracks whether or not the DelegatedFrameHost's owner
has set it to be visible.

BUG=623716

Committed: https://crrev.com/4309d664520802fe54ba603622b1222741e427aa
Cr-Commit-Position: refs/heads/master@{#404469}
==========

[commit-bot: I haz the power, 2016-07-08 19:52:24]

Patchset 2 (id:??) landed as
https://crrev.com/4309d664520802fe54ba603622b1222741e427aa
Cr-Commit-Position: refs/heads/master@{#404469}