content/browser/renderer_host/browser_compositor_view_mac.mm - Issue 2125143004: Mac: Clean up visibility state tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/browser_compositor_view_mac.mm

Issue 2125143004: Mac: Clean up visibility state tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_dfh

Patch Set: Use state instead Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/browser_compositor_view_mac.mm

diff --git a/content/browser/renderer_host/browser_compositor_view_mac.mm b/content/browser/renderer_host/browser_compositor_view_mac.mm

index 0593c725a0f9c61b3315c9d478838ea4adfd3d5e..a8e2fa985bbaee4639d920b06a1ba8a7cda78a44 100644

--- a/content/browser/renderer_host/browser_compositor_view_mac.mm

+++ b/content/browser/renderer_host/browser_compositor_view_mac.mm

@@ -391,10 +391,7 @@ void OnCompositingShuttingDown(ui::Compositor* compositor) override {}

}

bool BrowserCompositorMac::DelegatedFrameHostIsVisible() const {

- // TODO(ccameron): This should return the same value as

- // |render_widget_host_is_hidden_|, rather than going back to the

- // RenderWidgetHostImpl.

- return client_->BrowserCompositorMacIsVisible();

+ return state_ == HasAttachedCompositor;

}

SkColor BrowserCompositorMac::DelegatedFrameHostGetGutterColor(