Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2125143004: Mac: Clean up visibility state tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_dfh
Patch Set: Use state instead Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 072bc66ab821e03b850cd8a13c084b683100b51b..37802c9acb71680b0ae02d200d28403d55b43d9e 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -408,10 +408,6 @@ float FlipYFromRectToScreen(float y, float rect_height) {
return cocoa_view_;
}
-bool RenderWidgetHostViewMac::BrowserCompositorMacIsVisible() const {
- return !render_widget_host_->is_hidden();
-}
-
SkColor RenderWidgetHostViewMac::BrowserCompositorMacGetGutterColor(
SkColor color) const {
// When making an element on the page fullscreen the element's background
@@ -1305,14 +1301,6 @@ float FlipYFromRectToScreen(float y, float rect_height) {
page_at_minimum_scale_ =
frame.metadata.page_scale_factor == frame.metadata.min_page_scale_factor;
if (frame.delegated_frame_data) {
- // TODO(ccameron): This would not be needed if BrowserCompostiorMac were to
- // correctly subscribe to the show and hide notifications for
- // RenderWidgetHostImpl. We do not correctly subscribe to these
- // notifications because we want to set the hide property property only
- // after all notifications (the thumbnailer in particular) have all
- // completed.
- browser_compositor_->SetRenderWidgetHostIsHidden(
- render_widget_host_->is_hidden());
browser_compositor_->SwapCompositorFrame(output_surface_id,
std::move(frame));
SendVSyncParametersToRenderer();
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698