Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2123313002: Mac: Further clean up RWHVMac<->DelegatedFrameHost (Closed)

Created:
4 years, 5 months ago by ccameron
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Further clean up RWHVMac<->DelegatedFrameHost This removes the strangeness whereby the BrowserCompositorMac would own the DelegatedFrameHost, but its owner, the RenderWidgetHostViewMac, would be the DelegatedFrameHostClient. BUG=625610 Committed: https://crrev.com/69170b87c992e07df18559ba1a50fb9b41a5988b Cr-Commit-Position: refs/heads/master@{#404006}

Patch Set 1 #

Patch Set 2 : Add todo #

Patch Set 3 : Fix crash in tryjob #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -140 lines) Patch
M content/browser/renderer_host/browser_compositor_view_mac.h View 7 chunks +55 lines, -11 lines 0 comments Download
M content/browser/renderer_host/browser_compositor_view_mac.mm View 1 2 8 chunks +109 lines, -24 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 4 chunks +12 lines, -29 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 7 chunks +19 lines, -76 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
ccameron
After staring at this long enough, it seemed like the right thing to do. I'll ...
4 years, 5 months ago (2016-07-06 19:21:46 UTC) #2
enne (OOO)
This is nice cleanup! lgtm
4 years, 5 months ago (2016-07-06 20:53:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123313002/40001
4 years, 5 months ago (2016-07-07 00:19:13 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 00:24:57 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 00:25:04 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:26:20 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/69170b87c992e07df18559ba1a50fb9b41a5988b
Cr-Commit-Position: refs/heads/master@{#404006}

Powered by Google App Engine
This is Rietveld 408576698