SubZero: legalize for f32/f64 constants in MIPS32

SubZero: legalize for f32/f64 constants in MIPS32

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d1e977762ab3a9f97d25f4665c8589f4078ad54a

[mohit.bhakkad, 2016-07-05 06:22:50]

Description was changed from

==========
legalize for f32/f64 constants
==========

to

==========
SubZero: legalize for f32/f64 constants in MIPS32
==========

[mohit.bhakkad, 2016-07-05 09:09:39]

mohit.bhakkad@imgtec.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com,
stichnot@chromium.org

[mohit.bhakkad, 2016-07-05 09:10:34]

I will add code which adds Labels in data section if this patch looks good.

[mohit.bhakkad, 2016-07-05 12:53:28]

Moving all part that takes care of constant types under one condition, to avoid
code to flow through wrong part.

[Jim Stichnoth, 2016-07-05 14:29:27]

https://codereview.chromium.org/2123723002/diff/20001/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/2123723002/diff/20001/src/IceInstMIPS32.h#new...
src/IceInstMIPS32.h:31: enum relocOp { no, hi, lo };
Capitalize these per LLVM coding convention.  I.e.:

  enum RelopOp { No, Hi, Lo };

Also, our style for enum values like this is usually to apply some unique
prefix, e.g.

enum RelopOp { RO_No, RO_Hi, RO_Lo };

https://codereview.chromium.org/2123723002/diff/20001/src/IceInstMIPS32.h#new...
src/IceInstMIPS32.h:33: inline void emitRelocOp(Ostream &Str, relocOp reloc) {
Also capitalize variable names, i.e. "Reloc".

https://codereview.chromium.org/2123723002/diff/20001/src/IceInstMIPS32.h#new...
src/IceInstMIPS32.h:121: Variable *Base;
Seems like these fields could be "final", i.e.

  Variable *const Base;
  Operand *const ImmOffset;
  const AddrMode Mode;

https://codereview.chromium.org/2123723002/diff/20001/src/IceInstMIPS32.h#new...
src/IceInstMIPS32.h:551: relocOp reloc;
maybe "const relocOp reloc" ?

https://codereview.chromium.org/2123723002/diff/20001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2123723002/diff/20001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:1024: ConstantInteger32 *Offset =
llvm::cast<ConstantInteger32>(Mem->getOffset());
auto *Offset = ...

[mohit.bhakkad, 2016-07-06 08:00:28]

https://codereview.chromium.org/2123723002/diff/20001/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/2123723002/diff/20001/src/IceInstMIPS32.h#new...
src/IceInstMIPS32.h:121: Variable *Base;
On 2016/07/05 14:29:27, stichnot wrote:
> Seems like these fields could be "final", i.e.
> 
>   Variable *const Base;
>   Operand *const ImmOffset;
>   const AddrMode Mode;

I didn't changed Base to constant pointer, as its causing incompatible
translation error at IceInstMIPS32.cpp:55, and Vars is declared in common arch
are.

[Jim Stichnoth, 2016-07-07 11:52:21]

https://codereview.chromium.org/2123723002/diff/40001/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/2123723002/diff/40001/src/IceInstMIPS32.h#new...
src/IceInstMIPS32.h:306: RelocOp Reloc;
const RelopOp Reloc;

https://codereview.chromium.org/2123723002/diff/40001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2123723002/diff/40001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:1024: ConstantInteger32 *Offset =
llvm::cast<ConstantInteger32>(Mem->getOffset());
auto *Offset = ...

[mohit.bhakkad, 2016-07-07 12:02:56]

On 2016/07/07 11:52:21, stichnot wrote:
> https://codereview.chromium.org/2123723002/diff/40001/src/IceInstMIPS32.h
> File src/IceInstMIPS32.h (right):
> 
>
https://codereview.chromium.org/2123723002/diff/40001/src/IceInstMIPS32.h#new...
> src/IceInstMIPS32.h:306: RelocOp Reloc;
> const RelopOp Reloc;
> 
>
https://codereview.chromium.org/2123723002/diff/40001/src/IceTargetLoweringMI...
> File src/IceTargetLoweringMIPS32.cpp (right):
> 
>
https://codereview.chromium.org/2123723002/diff/40001/src/IceTargetLoweringMI...
> src/IceTargetLoweringMIPS32.cpp:1024: ConstantInteger32 *Offset =
> llvm::cast<ConstantInteger32>(Mem->getOffset());
> auto *Offset = ...

Sorry for the miss, changed as suggested.

[Jim Stichnoth, 2016-07-07 12:05:12]

lgtm

[Jim Stichnoth, 2016-07-07 12:08:29]

Description was changed from

==========
SubZero: legalize for f32/f64 constants in MIPS32
==========

to

==========
SubZero: legalize for f32/f64 constants in MIPS32

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-07-07 12:08:33]

Committed patchset #4 (id:60001) manually as
d1e977762ab3a9f97d25f4665c8589f4078ad54a (presubmit successful).