Switch chrome_elf exception handling from breakpad to crashpad

Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching on the exe and disallow the call. This is to prevent CRT from overwriting crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the chrome_elf_common target. Previously this dependency came in through the chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky

Committed: https://crrev.com/52c55bd8b84076cccdc877538787da279a8a1bf4
Cr-Commit-Position: refs/heads/master@{#406403}

[ananta, 2016-07-06 12:22:52]

ananta@chromium.org changed reviewers:
+ robertshield@chromium.org, scottmg@chromium.org, wez@chromium.org

[ananta, 2016-07-06 12:22:53]

+wez for blimp owners

+robertshield for everything.
The only changes between this and the earlier patch
https://codereview.chromium.org/2114533002/ which got reverted is the list of
keys being updated in chrome_crash_reporter_client_win.cc. I also added comments
to the all three crash keys files to keep the lists in sync.

TBR'ing sky as the changes are the same in the other files.

[ananta, 2016-07-06 13:27:08]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

[ananta, 2016-07-06 13:27:52]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments
to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

[robertshield, 2016-07-06 14:33:24]

Changes to crash keys LGTM, let me know if you want a full re-review.

[ananta, 2016-07-06 18:11:36]

On 2016/07/06 14:33:24, robertshield wrote:
> Changes to crash keys LGTM, let me know if you want a full re-review.

Thanks. No other changes in this patch. Hopefully third time is the charm.

[Wez, 2016-07-06 19:36:00]

nit: Description contains two copies of "Switch chrome_elf exception handling
from breakpad to crashpad.".

[Wez, 2016-07-06 19:36:50]

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_keys.cc (right):

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_keys.cc:18: //    RegisterCrashKeysHelper()
We don't build the Blimp Engine for Windows, so I don't think we need this
comment?

[ananta, 2016-07-07 12:43:20]

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_keys.cc (right):

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_keys.cc:18: //    RegisterCrashKeysHelper()
On 2016/07/06 19:36:50, Wez wrote:
> We don't build the Blimp Engine for Windows, so I don't think we need this
> comment?

Yes. While we don't build Blimp for Windows, the crash keys are mostly common
between all three files. I think the comment helps?

[ananta, 2016-07-08 13:44:42]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments
to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments
to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

[ananta, 2016-07-08 13:45:05]

On 2016/07/06 19:36:00, Wez wrote:
> nit: Description contains two copies of "Switch chrome_elf exception handling
> from breakpad to crashpad.".

Thanks. Fixed.

[Wez, 2016-07-08 22:54:09]

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_keys.cc (right):

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_keys.cc:18: //    RegisterCrashKeysHelper()
On 2016/07/07 12:43:20, ananta wrote:
> On 2016/07/06 19:36:50, Wez wrote:
> > We don't build the Blimp Engine for Windows, so I don't think we need this
> > comment?
> 
> Yes. While we don't build Blimp for Windows, the crash keys are mostly common
> between all three files. I think the comment helps?

If they're "mostly common" then isn't staying up-to-date with the common
crash_keys.cc sufficient for the Blimp build?

If there were a chrome_crash_reporter_client[_posix].cc, for example, then it'd
be intuitive to refer to that here. Referring to a Windows-specific file is
confusing because presumably it is Windows-specific because its contents only
make sense on Windows, right?

[ananta, 2016-07-09 14:09:32]

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_keys.cc (right):

https://codereview.chromium.org/2123073002/diff/20001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_keys.cc:18: //    RegisterCrashKeysHelper()
On 2016/07/08 22:54:09, Wez wrote:
> On 2016/07/07 12:43:20, ananta wrote:
> > On 2016/07/06 19:36:50, Wez wrote:
> > > We don't build the Blimp Engine for Windows, so I don't think we need this
> > > comment?
> > 
> > Yes. While we don't build Blimp for Windows, the crash keys are mostly
common
> > between all three files. I think the comment helps?
> 
> If they're "mostly common" then isn't staying up-to-date with the common
> crash_keys.cc sufficient for the Blimp build?
> 
> If there were a chrome_crash_reporter_client[_posix].cc, for example, then
it'd
> be intuitive to refer to that here. Referring to a Windows-specific file is
> confusing because presumably it is Windows-specific because its contents only
> make sense on Windows, right?

Fair enough. Reverted the changes to the blimp_engine_crash_keys.cc file.

[Wez, 2016-07-11 17:38:37]

wez@chromium.org changed reviewers:
- wez@chromium.org

[Wez, 2016-07-11 17:38:38]

Thanks :D

-me

[ananta, 2016-07-18 21:46:42]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[ananta, 2016-07-18 21:47:04]

The CQ bit was unchecked by ananta@chromium.org

[ananta, 2016-07-18 21:47:22]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 21:48:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2016-07-18 21:49:15]

The CQ bit was unchecked by ananta@chromium.org

[ananta, 2016-07-18 22:05:56]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 22:06:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:17:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ananta, 2016-07-19 01:08:55]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:09:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2016-07-19 02:22:32]

The CQ bit was unchecked by ananta@chromium.org

[ananta, 2016-07-19 20:26:29]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-07-19 20:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertshield@chromium.org
Link to the patchset: https://codereview.chromium.org/2123073002/#ps200001
(title: "Update crash keys list in chrome_crash_reporter_client_win.cc")

[commit-bot: I haz the power, 2016-07-19 20:27:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:30:11]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[ananta, 2016-07-19 21:11:35]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-07-19 21:11:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertshield@chromium.org
Link to the patchset: https://codereview.chromium.org/2123073002/#ps220001
(title: "Rebased to tip and git cl format")

[commit-bot: I haz the power, 2016-07-19 21:12:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 22:41:07]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments
to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments
to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

[commit-bot: I haz the power, 2016-07-19 22:41:08]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-07-19 22:43:03]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments
to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows telemetry test fixes

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception
   handling mechanism in chrome_elf. We continue to handle exceptions in
chrome_elf in DllMain and in the blacklist interception code as before,
   i.e. we use crashpad to grab the dump and pass  the exception to the next
handler in the chain. I also added support in chrome_elf to not initialize
   crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has
   been deleted in this patch set.

7. Updated crash keys in chrome_crash_reporter_client_win.cc and added comments
to the crash key files to keep the lists in sync.

BUG=604923, crashpad:106, 568664
TBR=sky

Committed: https://crrev.com/52c55bd8b84076cccdc877538787da279a8a1bf4
Cr-Commit-Position: refs/heads/master@{#406403}
==========

[commit-bot: I haz the power, 2016-07-19 22:43:05]

Patchset 12 (id:??) landed as
https://crrev.com/52c55bd8b84076cccdc877538787da279a8a1bf4
Cr-Commit-Position: refs/heads/master@{#406403}