Switch chrome_elf exception handling from breakpad to crashpad

blimp/engine/app/blimp_engine_crash_keys.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/app/blimp_engine_crash_keys.h"
 
 #include "base/debug/crash_logging.h"
 #include "base/macros.h"
 #include "components/crash/core/common/crash_keys.h"
 
 namespace blimp {
 namespace engine {
 
 size_t RegisterEngineCrashKeys() {
   // For now these need to be kept relatively up to date with those in
-  // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys()
+  // 1. //chrome/common/crash_keys.cc::RegisterChromeCrashKeys()
+  // 2. //chrome/app/chrome_crash_reporter_client_win.cc::
+  //    RegisterCrashKeysHelper()

[Wez, 2016/07/06 19:36:50]

We don't build the Blimp Engine for Windows, so I don't think we need this
comment?

[ananta, 2016/07/07 12:43:20]

Yes. While we don't build Blimp for Windows, the crash keys are mostly common
between all three files. I think the comment helps?

[Wez, 2016/07/08 22:54:09]

If they're "mostly common" then isn't staying up-to-date with the common
crash_keys.cc sufficient for the Blimp build?

If there were a chrome_crash_reporter_client[_posix].cc, for example, then it'd
be intuitive to refer to that here. Referring to a Windows-specific file is
confusing because presumably it is Windows-specific because its contents only
make sense on Windows, right?

[ananta, 2016/07/09 14:09:32]

Fair enough. Reverted the changes to the blimp_engine_crash_keys.cc file.

   // All of the keys used in //content and //components/crash must show up
   // here.
   // TODO(marcinjb): Change the approach when http://crbug.com/598854 is
   // resolved.
   const base::debug::CrashKey engine_keys[] = {
       { crash_keys::kClientId, crash_keys::kSmallSize },
       { crash_keys::kChannel, crash_keys::kSmallSize },
       { crash_keys::kNumVariations, crash_keys::kSmallSize },
       { crash_keys::kVariations, crash_keys::kLargeSize },
 
@@ skipping 55 matching lines @@
       // Temporary for https://crbug.com/616149.
       { "existing_extension_pref_value_type", crash_keys::kSmallSize },
     };
 
   return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys),
                                     crash_keys::kChunkMaxLength);
 }
 
 }  // namespace engine
 }  // namespace blimp