Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3285)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2123073002: Switch chrome_elf exception handling from breakpad to crashpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased to tip and git cl format Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index 42e2093efa73d2506a45a87d0b89b2b4cc974dc0..e9689b38df932b2b18901cd444bea8761053c75e 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -72,7 +72,8 @@ size_t RegisterCrashKeysHelper() {
// The following keys may be chunked by the underlying crash logging system,
// but ultimately constitute a single key-value pair.
//
- // If you're adding keys here, please also add them to the list in
+ // For now these need to be kept relatively up to date with those in
+ // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys() and
// //blimp/engine/app/blimp_engine_crash_keys.cc
constexpr base::debug::CrashKey fixed_keys[] = {
{kMetricsClientId, kSmallSize},
@@ -89,6 +90,7 @@ size_t RegisterCrashKeysHelper() {
{kGPUVertexShaderVersion, kSmallSize},
// content/:
+ {"bad_message_reason", kSmallSize},
{"discardable-memory-allocated", kSmallSize},
{"discardable-memory-free", kSmallSize},
{kFontKeyName, kSmallSize},
@@ -102,6 +104,9 @@ size_t RegisterCrashKeysHelper() {
{kHungAudioThreadDetails, kSmallSize},
{kZeroEncodeDetails, kSmallSize},
+ // gin/:
+ {"v8-ignition", kSmallSize},
+
// Temporary for http://crbug.com/575245.
{"swapout_frame_id", kSmallSize},
{"swapout_proxy_id", kSmallSize},
@@ -136,8 +141,18 @@ size_t RegisterCrashKeysHelper() {
// Temporary for https://crbug.com/612711.
{"aci_wrong_sp_extension_id", kSmallSize},
+ // Temporary for http://crbug.com/621730
+ {"postmessage_src_origin", kMediumSize},
+ {"postmessage_dst_origin", kMediumSize},
+ {"postmessage_dst_url", kLargeSize},
+ {"postmessage_script_info", kLargeSize},
+
// Temporary for https://crbug.com/616149.
{"existing_extension_pref_value_type", crash_keys::kSmallSize},
+
+ // Temporary for https://crbug.com/625040
+ {"swdh_not_handled_message_type", crash_keys::kMediumSize},
+ {"swdh_not_handled_worker_status", crash_keys::kMediumSize},
};
// This dynamic set of keys is used for sets of key value pairs when gathering
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698