Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2439)

Unified Diff: chrome/browser/hang_monitor/hang_crash_dump_win.cc

Issue 2123073002: Switch chrome_elf exception handling from breakpad to crashpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased to tip and git cl format Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/hang_monitor/hang_crash_dump_win.cc
diff --git a/chrome/browser/hang_monitor/hang_crash_dump_win.cc b/chrome/browser/hang_monitor/hang_crash_dump_win.cc
index 456aa389cff48f8e0b0df454eb3cfeefb9338987..b38a22283e6362c28b95298d0481742a22fef7fa 100644
--- a/chrome/browser/hang_monitor/hang_crash_dump_win.cc
+++ b/chrome/browser/hang_monitor/hang_crash_dump_win.cc
@@ -24,9 +24,9 @@ void CrashDumpAndTerminateHungChildProcess(HANDLE hprocess) {
typedef HANDLE (__cdecl *DumpFunction)(HANDLE);
static DumpFunction request_dump = NULL;
if (!request_dump) {
- request_dump = reinterpret_cast<DumpFunction>(GetProcAddress(
- GetModuleHandle(chrome::kBrowserProcessExecutableName),
- "InjectDumpProcessWithoutCrash"));
+ request_dump = reinterpret_cast<DumpFunction>(
+ GetProcAddress(GetModuleHandle(chrome::kChromeElfDllName),
+ "InjectDumpProcessWithoutCrash"));
DCHECK(request_dump) << "Failed loading DumpProcessWithoutCrash: error " <<
GetLastError();
}
@@ -49,17 +49,16 @@ void CrashDumpForHangDebugging(HANDLE hprocess) {
if (hprocess == GetCurrentProcess()) {
typedef void (__cdecl *DumpFunction)();
DumpFunction request_dump = reinterpret_cast<DumpFunction>(GetProcAddress(
- GetModuleHandle(chrome::kBrowserProcessExecutableName),
- "DumpProcessWithoutCrash"));
+ GetModuleHandle(chrome::kChromeElfDllName), "DumpProcessWithoutCrash"));
DCHECK(request_dump) << "Failed loading DumpProcessWithoutCrash: error " <<
GetLastError();
if (request_dump)
request_dump();
} else {
typedef HANDLE (__cdecl *DumpFunction)(HANDLE);
- DumpFunction request_dump = reinterpret_cast<DumpFunction>(GetProcAddress(
- GetModuleHandle(chrome::kBrowserProcessExecutableName),
- "InjectDumpForHangDebugging"));
+ DumpFunction request_dump = reinterpret_cast<DumpFunction>(
+ GetProcAddress(GetModuleHandle(chrome::kChromeElfDllName),
+ "InjectDumpForHangDebugging"));
DCHECK(request_dump) << "Failed loading InjectDumpForHangDebugging: error "
<< GetLastError();
if (request_dump) {
« no previous file with comments | « chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698