Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient.

Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
Committed: https://crrev.com/0f44062484bc3111773212fd4bcae924d7551401
Cr-Commit-Position: refs/heads/master@{#406485}

[lfg, 2016-07-06 16:58:37]

lfg@chromium.org changed reviewers:
+ esprehn@chromium.org

[lfg, 2016-07-06 16:58:38]

Please take a look.

[kenrb, 2016-07-07 14:57:39]

Random drive-by question...

https://codereview.chromium.org/2121373002/diff/20001/content/renderer/render...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/2121373002/diff/20001/content/renderer/render...
content/renderer/render_view_impl.h:324: blink::WebWidgetClient* widgetClient()
override;
Is this override necessary because of the diamond-shaped inheritance pattern?

[lfg, 2016-07-07 15:16:43]

https://codereview.chromium.org/2121373002/diff/20001/content/renderer/render...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/2121373002/diff/20001/content/renderer/render...
content/renderer/render_view_impl.h:324: blink::WebWidgetClient* widgetClient()
override;
On 2016/07/07 14:57:38, kenrb wrote:
> Is this override necessary because of the diamond-shaped inheritance pattern?

Yes, you are right. Once all these methods are split, we should be able to get
rid of this (and get rid of the diamond inheritance), even before splitting
RenderView/RenderWidget.

[lfg, 2016-07-07 20:23:49]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2016-07-07 20:23:49]

+dcheng@ for review since Elliot is on vacation.

Please take a look.

[dcheng, 2016-07-11 06:58:15]

How long do you anticipate we'll need widgetClient() for? It feels pretty weird
to have to expose this.

[lfg, 2016-07-11 17:25:23]

On 2016/07/11 06:58:15, dcheng wrote:
> How long do you anticipate we'll need widgetClient() for? It feels pretty
weird
> to have to expose this.

I expect that the use of widgetClient() will be only in functions that are
duplicated by WebViewImpl and WebFrameWidgetImpl, and it should be removed once
WebViewImpl instantiates a WebFrameWidgetImpl instead of being one. The removal
should be straightforward, I expect that all the functions that use
widgetClient() should be deleted once we WebViewImpl can instantiate a
WebFrameWidgetImpl.

[dcheng, 2016-07-14 09:28:42]

Not a fan but if this is the best way forward, lgtm

[lfg, 2016-07-14 15:47:51]

+esprehn PTAL on content/renderer.

[lfg, 2016-07-19 15:55:40]

lfg@chromium.org changed reviewers:
+ avi@chromium.org

[lfg, 2016-07-19 15:55:41]

+avi for content/

[Avi (use Gerrit), 2016-07-19 16:09:19]

lgtm

[esprehn, 2016-07-19 16:21:36]

What's the plan for getting rid of this widgetClient() callback? How soon? It's
definitely ugly to have this all over :)

lgtm

[lfg, 2016-07-19 17:14:09]

On 2016/07/19 16:21:36, esprehn wrote:
> What's the plan for getting rid of this widgetClient() callback? How soon?
It's
> definitely ugly to have this all over :)

There's still several functions that need to be taken care before we can fully
split widget and view, but I'm hoping to be done with all the refactor by this
quarter.

[lfg, 2016-07-19 17:14:14]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:44:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lfg, 2016-07-20 03:02:08]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-20 03:02:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:27:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 04:27:33]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 04:28:47]

Description was changed from

==========
Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087

Committed: https://crrev.com/0f44062484bc3111773212fd4bcae924d7551401
Cr-Commit-Position: refs/heads/master@{#406485}
==========

[commit-bot: I haz the power, 2016-07-20 04:28:49]

Patchset 2 (id:??) landed as
https://crrev.com/0f44062484bc3111773212fd4bcae924d7551401
Cr-Commit-Position: refs/heads/master@{#406485}