third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2121373002: Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2121373002: Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adds override in RenderViewImpl to make sure we use the correct client Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 3e92e32a2f867341300bb60c550f5729a13a1c55..7c7840d43d92bb1d54609c1dcf43e3678f515fcc 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -4285,7 +4285,7 @@ void WebViewImpl::initializeLayerTreeView()

// FIXME: only unittests, click to play, Android printing, and printing (for headers and footers)

// make this assert necessary. We should make them not hit this code and then delete allowsBrokenNullLayerTreeView.

- DCHECK(m_layerTreeView || !m_client || m_client->allowsBrokenNullLayerTreeView());

+ DCHECK(m_layerTreeView || !m_client || m_client->widgetClient()->allowsBrokenNullLayerTreeView());

if (Platform::current()->isThreadedAnimationEnabled() && m_layerTreeView) {

m_linkHighlightsTimeline = CompositorAnimationTimeline::create();

« content/renderer/render_view_impl.h ('K') | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/public/web/WebViewClient.h » ('j') | no next file with comments »