content/renderer/render_view_impl.h - Issue 2121373002: Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 2121373002: Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adds override in RenderViewImpl to make sure we use the correct client Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 1ebdb174b2ea7463c1d874835d34e34c56f66056..7c3284fd0966ed0c06f748acf5c2affbbae96e29 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -293,7 +293,6 @@ class CONTENT_EXPORT RenderViewImpl

// TODO(lfg): Remove once WebViewClient no longer inherits from

// WebWidgetClient.

- bool allowsBrokenNullLayerTreeView() const override;

void closeWidgetSoon() override;

void convertViewportToWindow(blink::WebRect* rect) override;

void convertWindowToViewport(blink::WebFloatRect* rect) override;

@@ -322,6 +321,7 @@ class CONTENT_EXPORT RenderViewImpl

bool pageChanged) override;

blink::WebRect windowRect() override;

blink::WebRect windowResizerRect() override;

+ blink::WebWidgetClient* widgetClient() override;

kenrb 2016/07/07 14:57:38 Is this override necessary because of the diamond-

lfg 2016/07/07 15:16:43 Yes, you are right. Once all these methods are spl

// blink::WebViewClient implementation --------------------------------------

« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »