Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2121373002: Move allowsBrokenNullLayerTreeView calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adds override in RenderViewImpl to make sure we use the correct client Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 243
244 244
245 // Draggable regions ---------------------------------------------------- 245 // Draggable regions ----------------------------------------------------
246 246
247 // Informs the browser that the draggable regions have been updated. 247 // Informs the browser that the draggable regions have been updated.
248 virtual void draggableRegionsChanged() { } 248 virtual void draggableRegionsChanged() { }
249 249
250 // TODO(lfg): These methods are only exposed through WebViewClient while we 250 // TODO(lfg): These methods are only exposed through WebViewClient while we
251 // refactor WebView to not inherit from WebWidget. 251 // refactor WebView to not inherit from WebWidget.
252 // WebWidgetClient overrides. 252 // WebWidgetClient overrides.
253 bool allowsBrokenNullLayerTreeView() const override { return false; }
254 void closeWidgetSoon() override {} 253 void closeWidgetSoon() override {}
255 void convertViewportToWindow(WebRect* rect) override {} 254 void convertViewportToWindow(WebRect* rect) override {}
256 void convertWindowToViewport(WebFloatRect* rect) override {} 255 void convertWindowToViewport(WebFloatRect* rect) override {}
257 void didAutoResize(const WebSize& newSize) override {} 256 void didAutoResize(const WebSize& newSize) override {}
258 void didChangeCursor(const WebCursorInfo&) override {} 257 void didChangeCursor(const WebCursorInfo&) override {}
259 void didFocus() override {} 258 void didFocus() override {}
260 void didHandleGestureEvent(const WebGestureEvent& event, bool eventCancelled ) override {} 259 void didHandleGestureEvent(const WebGestureEvent& event, bool eventCancelled ) override {}
261 void didInvalidateRect(const WebRect&) override {} 260 void didInvalidateRect(const WebRect&) override {}
262 void didMeaningfulLayout(WebMeaningfulLayout) override {} 261 void didMeaningfulLayout(WebMeaningfulLayout) override {}
263 void didOverscroll(const WebFloatSize& overscrollDelta, const WebFloatSize& accumulatedOverscroll, const WebFloatPoint& positionInViewport, const WebFloatSi ze& velocityInViewport) override {} 262 void didOverscroll(const WebFloatSize& overscrollDelta, const WebFloatSize& accumulatedOverscroll, const WebFloatPoint& positionInViewport, const WebFloatSi ze& velocityInViewport) override {}
264 void didUpdateTextOfFocusedElementByNonUserInput() override {} 263 void didUpdateTextOfFocusedElementByNonUserInput() override {}
265 void hasTouchEventHandlers(bool) override {} 264 void hasTouchEventHandlers(bool) override {}
266 void initializeLayerTreeView() override {} 265 void initializeLayerTreeView() override {}
267 WebLayerTreeView* layerTreeView() override { return 0; } 266 WebLayerTreeView* layerTreeView() override { return 0; }
268 void onMouseDown(const WebNode& mouseDownNode) override {} 267 void onMouseDown(const WebNode& mouseDownNode) override {}
269 void resetInputMethod() override {} 268 void resetInputMethod() override {}
270 WebRect rootWindowRect() override { return WebRect(); } 269 WebRect rootWindowRect() override { return WebRect(); }
271 void scheduleAnimation() override {} 270 void scheduleAnimation() override {}
272 WebScreenInfo screenInfo() override { return WebScreenInfo(); } 271 WebScreenInfo screenInfo() override { return WebScreenInfo(); }
273 void setToolTipText(const WebString&, WebTextDirection hint) override {} 272 void setToolTipText(const WebString&, WebTextDirection hint) override {}
274 void setTouchAction(WebTouchAction touchAction) override {} 273 void setTouchAction(WebTouchAction touchAction) override {}
275 void setWindowRect(const WebRect&) override {} 274 void setWindowRect(const WebRect&) override {}
276 void showImeIfNeeded() override {} 275 void showImeIfNeeded() override {}
277 void showUnhandledTapUIIfNeeded(const WebPoint& tappedPosition, const WebNod e& tappedNode, bool pageChanged) override {} 276 void showUnhandledTapUIIfNeeded(const WebPoint& tappedPosition, const WebNod e& tappedNode, bool pageChanged) override {}
278 void show(WebNavigationPolicy) override {} 277 void show(WebNavigationPolicy) override {}
279 WebRect windowRect() override { return WebRect(); } 278 WebRect windowRect() override { return WebRect(); }
280 WebRect windowResizerRect() override { return WebRect(); } 279 WebRect windowResizerRect() override { return WebRect(); }
280 virtual WebWidgetClient* widgetClient() { return this; }
281 281
282 protected: 282 protected:
283 ~WebViewClient() { } 283 ~WebViewClient() { }
284 }; 284 };
285 285
286 } // namespace blink 286 } // namespace blink
287 287
288 #endif 288 #endif
OLDNEW
« content/renderer/render_view_impl.h ('K') | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698