Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 2120403002: Revert of Fix caching of sample locations (Closed)

Created:
4 years, 5 months ago by rmistry
Modified:
4 years, 5 months ago
Reviewers:
bsalomon, csmartdalton
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix caching of sample locations (patchset #3 id:40001 of https://codereview.chromium.org/2111423002/ ) Reason for revert: Seems to be causing Chromium roll failures: * https://codereview.chromium.org/2120373003 * https://codereview.chromium.org/2117193002 * https://codereview.chromium.org/2124653002 Original issue's description: > Fix caching of sample locations > > The original caching logic for sample locations wishfully assumed that > the GPU would always use the same sample pattern for render targets > that had the same number of samples. It turns out we can't rely on > that. This change improves the caching logic to handle mismatched > simple patterns with the same count, and adds a unit test that > emulates different sample patterns observed on real hardware. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111423002 > > Committed: https://skia.googlesource.com/skia/+/09d49a3bfe2d1e652a648ce1ea0962b38d10d166 TBR=bsalomon@google.com,csmartdalton@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/42e6798696ac3a93a2b7ba7a9d6a84b77eba0116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -290 lines) Patch
M include/gpu/GrRenderTarget.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 5 chunks +14 lines, -24 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +52 lines, -57 lines 0 comments Download
M src/gpu/GrRenderTargetPriv.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
D tests/GpuSampleLocationsTest.cpp View 1 chunk +0 lines, -193 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
Created Revert of Fix caching of sample locations
4 years, 5 months ago (2016-07-05 00:44:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120403002/1
4 years, 5 months ago (2016-07-05 00:45:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/42e6798696ac3a93a2b7ba7a9d6a84b77eba0116
4 years, 5 months ago (2016-07-05 00:45:11 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 00:45:12 UTC) #6
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698