Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 211933007: [SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness. (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
Reviewers:
haraken, pdr.
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, oilpan-reviews
Visibility:
Public.

Description

[SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness. After r169941, the SVG leak tests reports failures, but delta is <0, so number of live nodes is not increasing. This CL loosen the check. Also removes FIXME comments in the tests. BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170010

Patch Set 1 #

Total comments: 2

Patch Set 2 : use collectAll #

Patch Set 3 : == #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M LayoutTests/svg/animations/smil-leak-element-instances.svg View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M LayoutTests/svg/animations/smil-leak-elements.svg View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kouhei (in TOK)
6 years, 9 months ago (2014-03-26 03:18:54 UTC) #1
kouhei (in TOK)
+oilpan-reviews
6 years, 9 months ago (2014-03-26 03:19:24 UTC) #2
haraken
It's mysterious that the delta becomes negative in the oilpan world. I might want to ...
6 years, 9 months ago (2014-03-26 03:39:03 UTC) #3
haraken
I remember I implemented GCController.collectAll() which collects all garbage. What happens if you use it?
6 years, 9 months ago (2014-03-26 03:44:14 UTC) #4
kouhei (in TOK)
On 2014/03/26 03:44:14, haraken wrote: > I remember I implemented GCController.collectAll() which collects all garbage. ...
6 years, 9 months ago (2014-03-26 03:51:39 UTC) #5
haraken
On 2014/03/26 03:51:39, kouhei wrote: > On 2014/03/26 03:44:14, haraken wrote: > > I remember ...
6 years, 9 months ago (2014-03-26 03:55:38 UTC) #6
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 03:55:56 UTC) #7
kouhei (in TOK)
The CQ bit was unchecked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 03:55:57 UTC) #8
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 03:56:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/211933007/90001
6 years, 9 months ago (2014-03-26 03:56:14 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 03:56:43 UTC) #11
Message was sent while issue was closed.
Change committed as 170010

Powered by Google App Engine
This is Rietveld 408576698