Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: LayoutTests/svg/animations/smil-leak-element-instances.svg

Issue 211933007: [SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: == Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/animations/smil-leak-element-instances.svg
diff --git a/LayoutTests/svg/animations/smil-leak-element-instances.svg b/LayoutTests/svg/animations/smil-leak-element-instances.svg
index 218294cc4d303cee19d1d56da49c6534371c3494..560e41aa39d302c1afaba4b52abe2c459c10755f 100644
--- a/LayoutTests/svg/animations/smil-leak-element-instances.svg
+++ b/LayoutTests/svg/animations/smil-leak-element-instances.svg
@@ -34,17 +34,15 @@ function createAnimatedRectInstance() {
function cleanup() {
// Collect garbage before recording starting live node count, in case there are live elements from previous tests.
- // FIXME: Unclear why two calls to collect() are required, see crbug.com/307614
- GCController.collect();
- GCController.collect();
+ GCController.collectAll();
var originalLiveElements = internals.numberOfLiveNodes();
while (g.hasChildNodes())
g.removeChild(g.lastChild);
- GCController.collect();
+ GCController.collectAll();
- // FIXME: Why is this 400 instead of 200?
+ // This is 400 instead of 200 as it creates shadow tree elements.
var liveDelta = originalLiveElements - internals.numberOfLiveNodes() - 400;
if (liveDelta == 0)
log("PASS");
« no previous file with comments | « no previous file | LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698