LayoutTests/svg/animations/smil-leak-elements.svg - Issue 211933007: [SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/animations/smil-leak-elements.svg

Issue 211933007: [SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: == Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/svg/animations/smil-leak-elements.svg

diff --git a/LayoutTests/svg/animations/smil-leak-elements.svg b/LayoutTests/svg/animations/smil-leak-elements.svg

index 3c4358d1fd4f1572d21059441e46ed39cbcb60bc..040aec71988d15e416f77ab70b76908755890be6 100644

--- a/LayoutTests/svg/animations/smil-leak-elements.svg

+++ b/LayoutTests/svg/animations/smil-leak-elements.svg

@@ -32,15 +32,13 @@ function createAnimatedRect() {

function cleanup() {

// Collect garbage before recording starting live node count, in case there are live elements from previous tests.

- // FIXME: Unclear why two calls to collect() are required, see crbug.com/307614

- GCController.collect();

+ GCController.collectAll();

var originalLiveElements = internals.numberOfLiveNodes();

while (g.hasChildNodes())

g.removeChild(g.lastChild);

- GCController.collect();

+ GCController.collectAll();

var liveDelta = originalLiveElements - internals.numberOfLiveNodes() - 200;

if (liveDelta == 0)

« no previous file with comments | « LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg ('k') | no next file » | no next file with comments »