Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

Issue 211933007: [SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: == Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg
diff --git a/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg b/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg
index bc7fdae059a3a0f9e1657dcae2aaea0bb9fde722..95ffa6c28491e09515439f75cd9b5af4d137273e 100644
--- a/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg
+++ b/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg
@@ -34,17 +34,15 @@ function createAnimatedRectInstance() {
function cleanup() {
// Collect garbage before recording starting live node count, in case there are live elements from previous tests.
- // FIXME: Unclear why two calls to collect() are required, see crbug.com/307614
- GCController.collect();
- GCController.collect();
+ GCController.collectAll();
var originalLiveElements = internals.numberOfLiveNodes();
while (g.hasChildNodes())
g.removeChild(g.lastChild);
- GCController.collect();
+ GCController.collectAll();
- // FIXME: Why 400 and not 200?
+ // This is 400 instead of 200 as it creates shadow tree elements.
var liveDelta = originalLiveElements - internals.numberOfLiveNodes() - 400;
if (liveDelta == 0)
log("PASS");
« no previous file with comments | « LayoutTests/svg/animations/smil-leak-element-instances.svg ('k') | LayoutTests/svg/animations/smil-leak-elements.svg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698