Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2119283002: Use container::back() and container::pop_back() for content. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
clamy
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, posciak+watch_chromium.org, nektar+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, wjmaclean, aboxhall+watch_chromium.org, jam, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, dtseng+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, nhiroki, mcasas+watch+vc_chromium.org, jsbell+idb_chromium.org, michaeln, serviceworker-reviews, shuchen+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, kinuko+serviceworker, cmumford, horo+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use container::back() and container::pop_back() for content. Also convert !container.size() to container.empty(). Committed: https://crrev.com/76ee1f4987d0d00cd33a58c6c072031e03c0d2fd Cr-Commit-Position: refs/heads/master@{#404452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -72 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_coordinator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_value.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/notification_id_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 chunk +12 lines, -15 lines 0 comments Download
M content/browser/speech/endpointer/energy_endpointer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/webidbcursor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_type_util.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
4 years, 5 months ago (2016-07-07 23:27:45 UTC) #2
clamy
Thanks for the cleanup! Lgtm.
4 years, 5 months ago (2016-07-08 15:25:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119283002/1
4 years, 5 months ago (2016-07-08 17:17:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 18:54:59 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 18:55:03 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 18:55:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76ee1f4987d0d00cd33a58c6c072031e03c0d2fd
Cr-Commit-Position: refs/heads/master@{#404452}

Powered by Google App Engine
This is Rietveld 408576698