content/browser/notifications/notification_id_generator.cc - Issue 2119283002: Use container::back() and container::pop_back() for content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_id_generator.cc

Issue 2119283002: Use container::back() and container::pop_back() for content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_value.cc ('k') | content/browser/notifications/platform_notification_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_id_generator.cc

diff --git a/content/browser/notifications/notification_id_generator.cc b/content/browser/notifications/notification_id_generator.cc

index 254c83efdfdfc1d08933273f025aeaa6e515aae3..7bdbb2cfcc317319aa21b06543a7c506c9f36b5c 100644

--- a/content/browser/notifications/notification_id_generator.cc

+++ b/content/browser/notifications/notification_id_generator.cc

@@ -105,7 +105,7 @@ std::string NotificationIdGenerator::GenerateForNonPersistentNotification(

// tag is being used. Tags still identify uniqueness for the given origin.

stream << base::IntToString(!tag.empty());

- if (!tag.size()) {

+ if (tag.empty()) {

stream << base::IntToString(render_process_id_);

stream << kSeparator;