content/browser/appcache/appcache_internals_ui.cc - Issue 2119283002: Use container::back() and container::pop_back() for content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_internals_ui.cc

Issue 2119283002: Use container::back() and container::pop_back() for content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_internals_ui.cc

diff --git a/content/browser/appcache/appcache_internals_ui.cc b/content/browser/appcache/appcache_internals_ui.cc

index 0c83ce031fc8bc501af8a110584f021b6f234849..18eb9fcffe9e9ac1fde91da7b9069db0298a4aad 100644

--- a/content/browser/appcache/appcache_internals_ui.cc

+++ b/content/browser/appcache/appcache_internals_ui.cc

@@ -265,7 +265,7 @@ void AppCacheInternalsUI::Proxy::RequestFileDetails(

}

void AppCacheInternalsUI::Proxy::HandleFileDetailsRequest() {

- if (preparing_response_ || !response_enquiries_.size() || !appcache_service_)

+ if (preparing_response_ || response_enquiries_.empty() || !appcache_service_)

return;

preparing_response_ = true;

appcache_service_->storage()->LoadResponseInfo(