Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2316)

Unified Diff: content/renderer/service_worker/service_worker_type_util.cc

Issue 2119283002: Use container::back() and container::pop_back() for content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/pepper_plugin_registry.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_type_util.cc
diff --git a/content/renderer/service_worker/service_worker_type_util.cc b/content/renderer/service_worker/service_worker_type_util.cc
index 35769afd267aded7e9c67b204696415e55d5c420..d1dae81973eb290c13f83ef0ec5ab6cd8a747341 100644
--- a/content/renderer/service_worker/service_worker_type_util.cc
+++ b/content/renderer/service_worker/service_worker_type_util.cc
@@ -20,7 +20,7 @@ namespace {
class HeaderVisitor : public blink::WebHTTPHeaderVisitor {
public:
- HeaderVisitor(ServiceWorkerHeaderMap* headers) : headers_(headers) {}
+ explicit HeaderVisitor(ServiceWorkerHeaderMap* headers) : headers_(headers) {}
virtual ~HeaderVisitor() {}
void visitHeader(const blink::WebString& name,
@@ -35,7 +35,7 @@ class HeaderVisitor : public blink::WebHTTPHeaderVisitor {
}
private:
- ServiceWorkerHeaderMap* headers_;
+ ServiceWorkerHeaderMap* const headers_;
};
std::unique_ptr<HeaderVisitor> MakeHeaderVisitor(
@@ -49,7 +49,7 @@ void GetServiceWorkerHeaderMapFromWebRequest(
const blink::WebServiceWorkerRequest& web_request,
ServiceWorkerHeaderMap* headers) {
DCHECK(headers);
- DCHECK(!headers->size());
+ DCHECK(headers->empty());
web_request.visitHTTPHeaderFields(MakeHeaderVisitor(headers).get());
}
@@ -57,7 +57,7 @@ void GetServiceWorkerHeaderMapFromWebResponse(
const blink::WebServiceWorkerResponse& web_response,
ServiceWorkerHeaderMap* headers) {
DCHECK(headers);
- DCHECK(!headers->size());
+ DCHECK(headers->empty());
web_response.visitHTTPHeaderFields(MakeHeaderVisitor(headers).get());
}
« no previous file with comments | « content/renderer/pepper/pepper_plugin_registry.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698