[test] Remove presubmit logic from test runner.

[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often
requires logic to remove the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921
Committed: https://crrev.com/9b4f0989437e14a557721079904a31dd9fad331a
Cr-Commit-Position: refs/heads/master@{#37447}

[Michael Achenbach, 2016-06-30 13:29:49]

Description was changed from

==========
[test] Remove presubmit logic from test runner.

BUG=
==========

to

==========
[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often adds logic to remove
the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921
==========

[Michael Achenbach, 2016-06-30 13:34:07]

Description was changed from

==========
[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often adds logic to remove
the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921
==========

to

==========
[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often
requires logic to remove the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921
==========

[Michael Achenbach, 2016-06-30 13:34:07]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org, jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-06-30 13:35:07]

PTAL

https://codereview.chromium.org/2114653002/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/2114653002/diff/1/Makefile#newcode351
Makefile:351: $(addsuffix .check,$(MODES)): $$(basename $$@)
We could also temporarily add it back here as dependency if you think that'd be
useful.

[Michael Achenbach, 2016-06-30 13:35:20]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 13:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 13:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 13:45:00]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18559)

[Jakob Kummerow, 2016-06-30 13:48:08]

lgtm

[Michael Achenbach, 2016-06-30 13:51:24]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 13:51:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-06-30 14:04:56]

lgtm

[Michael Achenbach, 2016-06-30 14:25:58]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-06-30 14:26:02]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-06-30 14:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2114653002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-30 14:26:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 14:28:32]

Description was changed from

==========
[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often
requires logic to remove the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921
==========

to

==========
[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often
requires logic to remove the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921
==========

[commit-bot: I haz the power, 2016-06-30 14:28:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 14:30:49]

Description was changed from

==========
[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often
requires logic to remove the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921
==========

to

==========
[test] Remove presubmit logic from test runner.

Having presubmit called from within the test runner often
requires logic to remove the call again.

After the GN transition it would be better if presubmit is
called by a wrapper script if needed at all. It is run
on upload and on the tryservers anyways.

BUG=chromium:474921

Committed: https://crrev.com/9b4f0989437e14a557721079904a31dd9fad331a
Cr-Commit-Position: refs/heads/master@{#37447}
==========

[commit-bot: I haz the power, 2016-06-30 14:30:51]

Patchset 2 (id:??) landed as
https://crrev.com/9b4f0989437e14a557721079904a31dd9fad331a
Cr-Commit-Position: refs/heads/master@{#37447}