Makefile - Issue 2114653002: [test] Remove presubmit logic from test runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 2114653002: [test] Remove presubmit logic from test runner. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@gn-test1

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Makefile

diff --git a/Makefile b/Makefile

index ffb5192bfa12fdb08d5f897b464cfabe3ce7fef8..5ea5c58efec54d1868deb1936439c582f3d62455 100644

--- a/Makefile

+++ b/Makefile

@@ -122,10 +122,6 @@ endif

ifeq ($(werror), no)

GYPFLAGS += -Dwerror=''

endif

-# presubmit=no

-ifeq ($(presubmit), no)

- TESTFLAGS += --no-presubmit

-endif

# strictaliasing=off (workaround for GCC-4.5)

ifeq ($(strictaliasing), off)

GYPFLAGS += -Dv8_no_strict_aliasing=1

@@ -392,7 +388,7 @@ $(addsuffix .check, $(ANDROID_ARCHES)): \

$(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@)

@tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \

--arch-and-mode=$(basename $@) \

- --timeout=600 --nopresubmit --noi18n \

+ --timeout=600 --noi18n \

--command-prefix="tools/nacl-run.py"

$(addsuffix .check, $(NACL_ARCHES)): \

« no previous file with comments | « no previous file | tools/run-tests.py » ('j') | no next file with comments »