Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: Makefile

Issue 2114653002: [test] Remove presubmit logic from test runner. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@gn-test1
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/run-tests.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 GYPFLAGS += -Dv8_random_seed=$(randomseed) 115 GYPFLAGS += -Dv8_random_seed=$(randomseed)
116 endif 116 endif
117 # soname_version=1.2.3 117 # soname_version=1.2.3
118 ifdef soname_version 118 ifdef soname_version
119 GYPFLAGS += -Dsoname_version=$(soname_version) 119 GYPFLAGS += -Dsoname_version=$(soname_version)
120 endif 120 endif
121 # werror=no 121 # werror=no
122 ifeq ($(werror), no) 122 ifeq ($(werror), no)
123 GYPFLAGS += -Dwerror='' 123 GYPFLAGS += -Dwerror=''
124 endif 124 endif
125 # presubmit=no
126 ifeq ($(presubmit), no)
127 TESTFLAGS += --no-presubmit
128 endif
129 # strictaliasing=off (workaround for GCC-4.5) 125 # strictaliasing=off (workaround for GCC-4.5)
130 ifeq ($(strictaliasing), off) 126 ifeq ($(strictaliasing), off)
131 GYPFLAGS += -Dv8_no_strict_aliasing=1 127 GYPFLAGS += -Dv8_no_strict_aliasing=1
132 endif 128 endif
133 # regexp=interpreted 129 # regexp=interpreted
134 ifeq ($(regexp), interpreted) 130 ifeq ($(regexp), interpreted)
135 GYPFLAGS += -Dv8_interpreted_regexp=1 131 GYPFLAGS += -Dv8_interpreted_regexp=1
136 endif 132 endif
137 # i18nsupport=off 133 # i18nsupport=off
138 ifeq ($(i18nsupport), off) 134 ifeq ($(i18nsupport), off)
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 --arch-and-mode=$(basename $@) \ 381 --arch-and-mode=$(basename $@) \
386 --timeout=600 \ 382 --timeout=600 \
387 --command-prefix="tools/android-run.py" $(TESTFLAGS) 383 --command-prefix="tools/android-run.py" $(TESTFLAGS)
388 384
389 $(addsuffix .check, $(ANDROID_ARCHES)): \ 385 $(addsuffix .check, $(ANDROID_ARCHES)): \
390 $(addprefix $$(basename $$@).,$(MODES)).check 386 $(addprefix $$(basename $$@).,$(MODES)).check
391 387
392 $(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@) 388 $(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@)
393 @tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \ 389 @tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \
394 --arch-and-mode=$(basename $@) \ 390 --arch-and-mode=$(basename $@) \
395 » --timeout=600 --nopresubmit --noi18n \ 391 » --timeout=600 --noi18n \
396 --command-prefix="tools/nacl-run.py" 392 --command-prefix="tools/nacl-run.py"
397 393
398 $(addsuffix .check, $(NACL_ARCHES)): \ 394 $(addsuffix .check, $(NACL_ARCHES)): \
399 $(addprefix $$(basename $$@).,$(MODES)).check 395 $(addprefix $$(basename $$@).,$(MODES)).check
400 396
401 native.check: native 397 native.check: native
402 @tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR)/native \ 398 @tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR)/native \
403 --arch-and-mode=. $(TESTFLAGS) 399 --arch-and-mode=. $(TESTFLAGS)
404 400
405 SUPERFASTTESTMODES = ia32.release 401 SUPERFASTTESTMODES = ia32.release
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 tags: gtags.files $(wildcard $(shell cat gtags.files 2> /dev/null)) 517 tags: gtags.files $(wildcard $(shell cat gtags.files 2> /dev/null))
522 @(ctags --version | grep 'Exuberant Ctags' >/dev/null) || \ 518 @(ctags --version | grep 'Exuberant Ctags' >/dev/null) || \
523 (echo "Please install Exuberant Ctags (check 'ctags --version')" >&2; false) 519 (echo "Please install Exuberant Ctags (check 'ctags --version')" >&2; false)
524 ctags --fields=+l -L $< 520 ctags --fields=+l -L $<
525 521
526 tags.clean: 522 tags.clean:
527 rm -r tags 523 rm -r tags
528 524
529 dependencies builddeps: 525 dependencies builddeps:
530 $(error Use 'gclient sync' instead) 526 $(error Use 'gclient sync' instead)
OLDNEW
« no previous file with comments | « no previous file | tools/run-tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698