Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/run-tests.py

Issue 2114653002: [test] Remove presubmit logic from test runner. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@gn-test1
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index 09f301854a46a1006d949d26c103e5f8b2572720..1fc991eeb58b29d3274ddc670f4d518a7b6ffdac 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -279,7 +279,7 @@ def BuildOptions():
default=(utils.GuessOS() != "linux"),
dest="no_network", action="store_true")
result.add_option("--no-presubmit", "--nopresubmit",
- help='Skip presubmit checks',
+ help='Skip presubmit checks (deprecated)',
default=False, dest="no_presubmit", action="store_true")
result.add_option("--no-snap", "--nosnap",
help='Test a build compiled without snapshot.',
@@ -490,11 +490,7 @@ def ProcessOptions(options):
# Special processing of other options, sorted alphabetically.
if options.buildbot:
- # Buildbots run presubmit tests as a separate step.
- options.no_presubmit = True
options.no_network = True
- if options.download_data_only:
- options.no_presubmit = True
if options.command_prefix:
print("Specifying --command-prefix disables network distribution, "
"running tests locally.")
@@ -636,10 +632,6 @@ def Main():
print ' '.join(sys.argv)
exit_code = 0
- if not options.no_presubmit:
- print ">>> running presubmit tests"
- exit_code = subprocess.call(
- [sys.executable, join(BASE_DIR, "tools", "presubmit.py")])
suite_paths = utils.GetSuitePaths(join(BASE_DIR, "test"))
« no previous file with comments | « Makefile ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698