Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2112503002: Implement super in mixins. (Closed)

Created:
4 years, 5 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
*Johnni Winther
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
sso://user/ahe/dart-sdk@malformed
Target Ref:
refs/heads/vm_patch_files
Visibility:
Public.

Description

Implement super in mixins.

Patch Set 1 #

Patch Set 2 : Synthetic type variables for use in mixin scope. #

Patch Set 3 : Add MixinApplicationScope #

Patch Set 4 : Named mixin applications. #

Patch Set 5 : Clone fields correctly, and handle bad hierarchies. #

Total comments: 3

Patch Set 6 : Remove experimenting code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -16 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 3 4 10 chunks +33 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 2 3 4 5 4 chunks +65 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2108673002 Patch 1

Dependent Patchsets:

Issue 2113653003 Patch 20001

Messages

Total messages: 7 (2 generated)
ahe
4 years, 5 months ago (2016-06-29 13:49:49 UTC) #3
ahe
Hang on, I found a problem.
4 years, 5 months ago (2016-06-29 15:20:29 UTC) #4
ahe
This is ready for review now.
4 years, 5 months ago (2016-06-30 14:05:45 UTC) #5
Johnni Winther
lgtm https://codereview.chromium.org/2112503002/diff/80001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/2112503002/diff/80001/pkg/compiler/lib/src/elements/modelx.dart#newcode2906 pkg/compiler/lib/src/elements/modelx.dart:2906: buildScope() { Add @override and return type. https://codereview.chromium.org/2112503002/diff/80001/pkg/compiler/lib/src/resolution/class_hierarchy.dart ...
4 years, 5 months ago (2016-06-30 14:16:30 UTC) #6
ahe
4 years, 5 months ago (2016-06-30 14:26:28 UTC) #7 
Thank you, Johnni. Nice catch!

https://codereview.chromium.org/2112503002/diff/80001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/class_hierarchy.dart (right):

https://codereview.chromium.org/2112503002/diff/80001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/class_hierarchy.dart:470: if
(member.library.isPlatformLibrary) return;
On 2016/06/30 14:16:30, Johnni Winther wrote:
> Why this exclusion?

This for for experimenting. I need to delete this.

Powered by Google App Engine
This is Rietveld 408576698