Implement super in mixins.

pkg/compiler/lib/src/resolution/resolution.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.resolution;
 
 import 'dart:collection' show Queue;
 
 import '../common.dart';
 import '../common/names.dart' show Identifiers;
@@ skipping 40 matching lines @@
 
 import 'class_hierarchy.dart';
 import 'class_members.dart' show MembersCreator;
 import 'constructors.dart';
 import 'members.dart';
 import 'registry.dart';
 import 'signatures.dart';
 import 'tree_elements.dart';
 import 'typedefs.dart';
 
+// TODO(ahe): This should be a compiler option or something like that.
+const bool allowSuperInMixin = true;
+
 class ResolverTask extends CompilerTask {
   final ConstantCompiler constantCompiler;
 
   ResolverTask(Compiler compiler, this.constantCompiler) : super(compiler);
 
   String get name => 'Resolver';
 
   Resolution get resolution => compiler.resolution;
 
   Parsing get parsing => compiler.parsing;
@@ skipping 185 matching lines @@
         visitor.visit(tree.body);
       }
 
       // Get the resolution tree and check that the resolved
       // function doesn't use 'super' if it is mixed into another
       // class. This is the part of the 'super' mixin check that
       // happens when a function is resolved after the mixin
       // application has been performed.
       TreeElements resolutionTree = registry.mapping;
       ClassElement enclosingClass = element.enclosingClass;
-      if (enclosingClass != null) {
+      if (!allowSuperInMixin && enclosingClass != null) {
         // TODO(johnniwinther): Find another way to obtain mixin uses.
         Iterable<MixinApplicationElement> mixinUses =
             compiler.world.allMixinUsesOf(enclosingClass);
         ClassElement mixin = enclosingClass;
         for (MixinApplicationElement mixinApplication in mixinUses) {
           checkMixinSuperUses(resolutionTree, mixinApplication, mixin);
         }
       }
 
       // TODO(9631): support noSuchMethod on native classes.
@@ skipping 442 matching lines @@
     if (!mixin.superclass.isObject) {
       reporter.reportErrorMessage(mixin, MessageKind.ILLEGAL_MIXIN_SUPERCLASS);
     }
 
     // Check that the mixed in class doesn't have any constructors and
     // make sure we aren't mixing in methods that use 'super'.
     mixin.forEachLocalMember((AstElement member) {
       if (member.isGenerativeConstructor && !member.isSynthesized) {
         reporter.reportErrorMessage(
             member, MessageKind.ILLEGAL_MIXIN_CONSTRUCTOR);
-      } else {
+      } else if (!allowSuperInMixin) {
         // Get the resolution tree and check that the resolved member
         // doesn't use 'super'. This is the part of the 'super' mixin
         // check that happens when a function is resolved before the
         // mixin application has been performed.
         // TODO(johnniwinther): Obtain the [TreeElements] for [member]
         // differently.
         if (compiler.enqueuer.resolution.hasBeenProcessed(member)) {
           checkMixinSuperUses(
               member.resolvedAst.elements, mixinApplication, mixin);
         }
@@ skipping 358 matching lines @@
   TreeElements get treeElements {
     assert(invariant(this, _treeElements != null,
         message: "TreeElements have not been computed for $this."));
     return _treeElements;
   }
 
   void reuseElement() {
     _treeElements = null;
   }
 }