Effective type can be malformed.

Effective type can be malformed.

[ahe, 2016-06-28 14:29:29]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2016-06-28 14:29:29]

Test in rasta/test/kernel/regression/generic_factory.dart.

[Johnni Winther, 2016-06-30 07:51:12]

The fix is only partial. This simpler test crashes in resolveRedirectionChain:

abstract class A {
  factory A.a() = B.a;
}

class B implements A {
  factory B.a() = Missing;
}

main() {
  new A.a();
}

[ahe, 2016-06-30 09:17:18]

On 2016/06/30 07:51:12, Johnni Winther wrote:
> The fix is only partial. This simpler test crashes in resolveRedirectionChain:
> 
> abstract class A {
>   factory A.a() = B.a;
> }
> 
> class B implements A {
>   factory B.a() = Missing;
> }
> 
> main() {
>   new A.a();
> }

This doesn't happen in my version. I instrumented resolveRedirectionChain to
print what it's being called with:

$ ./bin/rastak_developer --library test.dart 
Loading platform libraries took: 3532.000ms
resolveRedirectionChain(factory_constructor(A#a), =B.a;)
test.dart:6:17:
Warning: Cannot resolve 'Missing'.
factory B.a() = Missing;
                ^^^^^^^
library;
import self as self;
import "dart:core" as core;

abstract class A extends core::Object {
  static factory a() → self::A
    invalid-statement;
}
class B extends core::Object implements self::A {
  static factory a() → self::B
    invalid-statement;
}
static method main() → dynamic {
  invalid-expression.call();
}

[Johnni Winther, 2016-06-30 09:21:55]

LGTM

I'm OK with the fix, but we need to fix the latent problem (probably susceptible
to resolution order) at some point.