Teach CQ status app to check login status of users.

Teach CQ status app to check login status of users.

BUG=623614
R=sergiyb@chromium.org

Committed: https://chromium.googlesource.com/infra/infra/+/b2125eddaaa1e69a1949d16997234f8885b19ad8

[tandrii(chromium), 2016-06-30 23:27:50]

Description was changed from

==========
Teach CQ status app to check login status of users.

BUG=623614
R=sergiyb@google.com
==========

to

==========
Teach CQ status app to check login status of users.

BUG=623614
R=sergiyb@chromium.org
==========

[tandrii(chromium), 2016-06-30 23:27:50]

tandrii@chromium.org changed reviewers:
+ sergiyb@chromium.org
- sergiyb@google.com

[tandrii(chromium), 2016-06-30 23:28:11]

WDYT about this approach?

[Paweł Hajdan Jr., 2016-07-01 14:20:39]

phajdan.jr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-07-01 14:20:39]

Looks good. Please let me know when it's ready for final review.

[tandrii(chromium), 2016-07-01 15:27:58]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 15:28:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 15:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 15:41:59]

Dry run: Try jobs failed on following builders:
  Infra Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%...)

[Sergiy Byelozyorov, 2016-07-01 17:13:06]

lgtm

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/handlers/stats_viewer.py (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/handlers/stats_viewer.py:7: from shared.utils
import minutes_per_day, read_access
for consistency with other files, please rewrite as

from shared import utils

and the update calls below to include utils. prefix

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/makefile (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/makefile:5: APP_ID ?= chromium-cq-status
why ?=

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/makefile:27: # appcfg.py -A $(APP_ID)
update_dispatch --version `git rev-parse --short HEAD`
looks like debug line to me... remove or uncomment

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/shared/config.py (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/shared/config.py:40: HOST_ACLS = {
I'd remove everything but the actual production hosts, but up to you...

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/shared/utils.py (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/shared/utils.py:58: if email_pattern is True:  #
Everyone.
I'd use 'everyone' rather than True. Then it's also clear in the config file.

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/shared/utils.py:77: return
host.split('-')[0].capitalize()
Not so friendly to developers trying to understand where the the resulting
string is coming from, but I like the approach anyway :-).

[tandrii(chromium), 2016-07-01 18:56:18]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 18:56:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-01 18:56:55]

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/handlers/stats_viewer.py (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/handlers/stats_viewer.py:7: from shared.utils
import minutes_per_day, read_access
On 2016/07/01 17:13:06, Sergiy Byelozyorov wrote:
> for consistency with other files, please rewrite as
> 
> from shared import utils
> 
> and the update calls below to include utils. prefix

Done.

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/makefile (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/makefile:5: APP_ID ?= chromium-cq-status
On 2016/07/01 17:13:06, Sergiy Byelozyorov wrote:
> why ?=

this means set only if not set before. This allows to deploy other apps  with:

APP_ID='whatever' make deploy

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/makefile:27: # appcfg.py -A $(APP_ID)
update_dispatch --version `git rev-parse --short HEAD`
On 2016/07/01 17:13:06, Sergiy Byelozyorov wrote:
> looks like debug line to me... remove or uncomment

not debug, wrote separately.

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/shared/config.py (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/shared/config.py:40: HOST_ACLS = {
On 2016/07/01 17:13:06, Sergiy Byelozyorov wrote:
> I'd remove everything but the actual production hosts, but up to you...

Done.

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
File appengine/chromium_cq_status/shared/utils.py (right):

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/shared/utils.py:58: if email_pattern is True:  #
Everyone.
On 2016/07/01 17:13:06, Sergiy Byelozyorov wrote:
> I'd use 'everyone' rather than True. Then it's also clear in the config file.

good idea.

https://codereview.chromium.org/2111713004/diff/40001/appengine/chromium_cq_s...
appengine/chromium_cq_status/shared/utils.py:77: return
host.split('-')[0].capitalize()
On 2016/07/01 17:13:06, Sergiy Byelozyorov wrote:
> Not so friendly to developers trying to understand where the the resulting
> string is coming from, but I like the approach anyway :-).

added comment.

[tandrii(chromium), 2016-07-01 19:07:14]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-07-01 19:07:19]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-07-01 19:07:19]

The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org
Link to the patchset: https://codereview.chromium.org/2111713004/#ps60001
(title: "Review and tests.")

[commit-bot: I haz the power, 2016-07-01 19:07:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 19:10:39]

Description was changed from

==========
Teach CQ status app to check login status of users.

BUG=623614
R=sergiyb@chromium.org
==========

to

==========
Teach CQ status app to check login status of users.

BUG=623614
R=sergiyb@chromium.org

Committed:
https://chromium.googlesource.com/infra/infra/+/b2125eddaaa1e69a1949d16997234...
==========

[commit-bot: I haz the power, 2016-07-01 19:10:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/b2125eddaaa1e69a1949d16997234...

[DJJAAM.COM, 2017-08-01 19:03:39]

https://gettutuapp.com/download/
https://appspopo.com/apk/tutuapp/

[onlinefree2525, 2017-08-29 08:20:17]

On 2017/08/01 19:03:39, DJJAAM.COM wrote:
> https://gettutuapp.com/download/
> https://appspopo.com/apk/tutuapp/

and http://www.bhimappdownloads.in/ http://www.latestapkapp.com/

[rakthith, 2017-08-31 09:39:02]

All most all the android apps are working with chrome by Arc welder. There are
many extensions available to run android app but Arc welder has the great code
with amazing functionality. It is very great to have Mobdro on PC using the web
browser because it can enable the users to watch free movies and channels on
computer. Use this page as reference and get
https://mobdroappdownload.co/mobdro-for-pc/ and it is the official hack or guide
to let you stream on your laptop screen.

[amber.gandotra, 2017-09-08 21:57:05]

https://tweakboxappdownload.com/
https://192168l254.online/