Teach CQ status app to check login status of users.

appengine/chromium_cq_status/shared/test/utils_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
+from contextlib import contextmanager
+from datetime import datetime
+import os
 
-from datetime import datetime
+from webtest.app import AppError
+from third_party.testing_utils import testing
+import main
+from shared import utils
 
-from third_party.testing_utils import testing
-from shared import utils
 
 
 class MockWebApp(object):
   def __init__(self):
     self.response = MockResponse()
 
 class MockResponse(object):
   def __init__(self):
     self.body = ''
     self.headers = MockHeaders()
 
   def write(self, text):
     self.body += text
 
 class MockHeaders(object):
   def __init__(self):
     self.is_cross_origin = False
     self.is_json_content = False
 
   def add_header(self, key, value): # pragma: no cover
     if key == "Access-Control-Allow-Origin":
       self.is_cross_origin = (value == "*")
     elif key == 'Content-Type':
       self.is_json_content = (value == 'application/json')
 
+
+@contextmanager
+def mock_host_acls(acls):
+  old = utils.HOST_ACLS['Development']
+  try:
+    utils.HOST_ACLS['Development'] = acls
+    yield
+  finally:
+    utils.HOST_ACLS['Development'] = old
+
+
+class TestPermissions(testing.AppengineTestCase):
+  app_module = main.app
+
+  def test_has_permission_chromium(self):
+    with mock_host_acls(utils.HOST_ACLS['chromium-cq-status.appspot.com']):
+      # No user.
+      self.assertTrue(utils.has_permission('read'))
+      self.assertFalse(utils.has_permission('write'))
+
+      self.mock_current_user('random', 'random@person.com')
+      self.assertTrue(utils.has_permission('read'))
+      self.assertFalse(utils.has_permission('write'))
+
+      self.mock_current_user(is_admin=True)
+      self.assertTrue(utils.has_permission('read'))
+      self.assertTrue(utils.has_permission('write'))
+
+      self.mock_current_user('real', 'real@chromium.org')
+      self.assertTrue(utils.has_permission('read'))
+      self.assertTrue(utils.has_permission('write'))
+
+      self.mock_current_user('real', 'real@google.com')
+      self.assertTrue(utils.has_permission('read'))
+      self.assertTrue(utils.has_permission('write'))
+
+  def test_has_permission_internal(self):
+    with mock_host_acls(utils.HOST_ACLS['internal-cq-status.appspot.com']):
+      # No user.
+      self.assertFalse(utils.has_permission('read'))
+      self.assertFalse(utils.has_permission('write'))
+
+      self.mock_current_user('random', 'random@person.com')
+      self.assertFalse(utils.has_permission('read'))
+      self.assertFalse(utils.has_permission('write'))
+
+      self.mock_current_user(is_admin=True)
+      self.assertTrue(utils.has_permission('read'))
+      self.assertTrue(utils.has_permission('write'))
+
+      self.mock_current_user('real', 'real@chromium.org')
+      self.assertFalse(utils.has_permission('read'))
+      self.assertFalse(utils.has_permission('write'))
+
+      self.mock_current_user('real', 'real@google.com')
+      self.assertTrue(utils.has_permission('read'))
+      self.assertTrue(utils.has_permission('write'))
+
+  def test_read_access_decorator(self):
+    # No user, which has read access.
+    self.assertTrue(utils.has_permission('read'))
+    self.test_app.get('/recent')
+
+    # Simulate read access requiring valid user.
+    with mock_host_acls(utils.HOST_ACLS['internal-cq-status.appspot.com']):
+      self.assertFalse(utils.has_permission('read'))
+      self.test_app.get('/recent')
+
+  def test_host_permissions(self):
+    try:
+      old = os.environ.pop('SERVER_SOFTWARE')
+      utils.HOST_ACLS[None] = {'read': 'something', 'write': True}
+      self.assertEqual(utils.get_host_permissions('read'), 'something')
+    finally:
+      utils.HOST_ACLS.pop(None)
+      os.environ['SERVER_SOFTWARE'] = old
+
+  def test_password_sha1(self):
+    self.assertEquals(
+        '018d644a17b71b65cef51fa0a523a293f2b3266f',
+        utils.password_sha1('cq'))
+
+
 class TestUtils(testing.AppengineTestCase):
   def test_filter_dict(self):
     self.assertEquals(
         {'b': 2, 'c': 3},
         utils.filter_dict({'a': 1, 'b': 2, 'c': 3}, ('b', 'c', 'd')))
 
-  def test_is_valid_user(self):
-    self.assertFalse(utils.is_valid_user())
-
-    self.mock_current_user('random', 'random@person.com')
-    self.assertFalse(utils.is_valid_user())
-
-    self.mock_current_user(is_admin=True)
-    self.assertTrue(utils.is_valid_user())
-
-    self.mock_current_user('real', 'real@chromium.org')
-    self.assertTrue(utils.is_valid_user())
-
-    self.mock_current_user('real', 'real@google.com')
-    self.assertTrue(utils.is_valid_user())
-
-    self.mock_current_user('fake', 'fake@google.comm')
-    self.assertFalse(utils.is_valid_user())
-
-    self.mock_current_user('fake', 'fake@google_com')
-    self.assertFalse(utils.is_valid_user())
-
-    self.mock_current_user('fake', 'fake@chromium.orgg')
-    self.assertFalse(utils.is_valid_user())
-
-    self.mock_current_user('fake', 'fake@chromium_org')
-    self.assertFalse(utils.is_valid_user())
-
-  def test_password_sha1(self):
-    self.assertEquals(
-        '018d644a17b71b65cef51fa0a523a293f2b3266f',
-        utils.password_sha1('cq'))
-
   def test_to_unix_timestamp(self):
     self.assertEquals(100,
         utils.to_unix_timestamp(datetime.utcfromtimestamp(100)))
     self.assertEquals(100.1,
         utils.to_unix_timestamp(datetime.utcfromtimestamp(100.1)))
     self.assertEquals(100.5,
         utils.to_unix_timestamp(datetime.utcfromtimestamp(100.5)))
     self.assertEquals(100.9,
         utils.to_unix_timestamp(datetime.utcfromtimestamp(100.9)))
     self.assertEquals(-100,
@@ skipping 72 matching lines @@
                       'codereview.chromium.org')
 
   def test_get_full_patchset_url(self):
     self.assertEquals(
         utils.get_full_patchset_url(
           'chromium-review.googlesource.com', '123', '567'),
         'https://chromium-review.googlesource.com/#/c/123/567')
     self.assertEquals(
         utils.get_full_patchset_url('codereview.chromium.org', '123', '567'),
         'https://codereview.chromium.org/123/#ps567')