Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: appengine/chromium_cq_status/makefile

Issue 2111713004: Teach CQ status app to check login status of users. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 APP_ID ?= chromium-cq-status
Sergiy Byelozyorov 2016/07/01 17:13:06 why ?=
tandrii(chromium) 2016/07/01 18:56:55 this means set only if not set before. This allows
5 NPM_VERSION := $(shell npm --version 2>/dev/null) 6 NPM_VERSION := $(shell npm --version 2>/dev/null)
6 BOWER_VERSION := $(shell bower --version 2>/dev/null) 7 BOWER_VERSION := $(shell bower --version 2>/dev/null)
7 GIT_REVISION := $(shell git rev-parse --short HEAD) 8 GIT_REVISION := $(shell git rev-parse --short HEAD)
8 9
9 check: 10 check:
10 ifndef NPM_VERSION 11 ifndef NPM_VERSION
11 $(error npm not found. Install from nodejs.org or see README) 12 $(error npm not found. Install from nodejs.org or see README)
12 endif 13 endif
13 ifndef BOWER_VERSION 14 ifndef BOWER_VERSION
14 @echo "bower not found. Installing:"; 15 @echo "bower not found. Installing:";
15 npm install -g bower 16 npm install -g bower
16 endif 17 endif
17 18
18 test: check 19 test: check
19 ./node_modules/karma/bin/karma start 20 ./node_modules/karma/bin/karma start
20 21
21 single-test: check 22 single-test: check
22 ./node_modules/karma/bin/karma start --single-run 23 ./node_modules/karma/bin/karma start --single-run
23 24
24 deploy: 25 deploy:
25 » appcfg.py --oauth2 update app.yaml highend.yaml --version `git rev-parse --short HEAD` 26 » appcfg.py --oauth2 update app.yaml highend.yaml --version `git rev-parse --short HEAD` -A $(APP_ID)
27 » # appcfg.py -A $(APP_ID) update_dispatch --version `git rev-parse --shor t HEAD`
Sergiy Byelozyorov 2016/07/01 17:13:06 looks like debug line to me... remove or uncomment
tandrii(chromium) 2016/07/01 18:56:55 not debug, wrote separately.
26 28
27 .PHONY: check test single-test 29 .PHONY: check test single-test
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698