appengine/chromium_cq_status/handlers/index.py - Issue 2111713004: Teach CQ status app to check login status of users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/chromium_cq_status/handlers/index.py

Issue 2111713004: Teach CQ status app to check login status of users. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Review and tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/chromium_cq_status/handlers/index.py

diff --git a/appengine/chromium_cq_status/handlers/index.py b/appengine/chromium_cq_status/handlers/index.py

index 136f250483c6bdb36fde38e079bf1376e6144646..e472c34154836b8f57b01ec07472f6d49361b02e 100644

--- a/appengine/chromium_cq_status/handlers/index.py

+++ b/appengine/chromium_cq_status/handlers/index.py

@@ -7,9 +7,12 @@ import webapp2

from shared import utils

class Index(webapp2.RequestHandler): # pragma: no cover

+ @utils.read_access

def get(self):

self.response.write(open('templates/index.html').read() % {

'login_url': users.create_login_url(),

- 'valid_user': bool(utils.is_valid_user()),

+ 'valid_user': utils.has_permission('read'),

+ 'host': utils.get_friendly_hostname(),

})