Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2111223002: [MD settings] set route on advanced page toggle (Closed)

Created:
4 years, 5 months ago by dschuyler
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, dpapad, tommycli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] set route on advanced page toggle This is a fix to set the route properly when going to basic or advanced pages (without going to a section within the page). BUG=593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/13892b7ca9ef20f61bbd609476a72d4b6fdd3ff9 Cr-Commit-Position: refs/heads/master@{#403565}

Patch Set 1 #

Total comments: 2

Patch Set 2 : making url optional #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 1 chunk +5 lines, -0 lines 2 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_router.js View 1 1 chunk +2 lines, -2 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
dschuyler
4 years, 5 months ago (2016-06-30 18:26:06 UTC) #4
Dan Beam
https://codereview.chromium.org/2111223002/diff/1/chrome/browser/resources/settings/settings_main/settings_main.js File chrome/browser/resources/settings/settings_main/settings_main.js (right): https://codereview.chromium.org/2111223002/diff/1/chrome/browser/resources/settings/settings_main/settings_main.js#newcode76 chrome/browser/resources/settings/settings_main/settings_main.js:76: url: '', where'd we land on omitting the url ...
4 years, 5 months ago (2016-06-30 23:40:27 UTC) #6
dschuyler
Made url optional. https://codereview.chromium.org/2111223002/diff/1/chrome/browser/resources/settings/settings_main/settings_main.js File chrome/browser/resources/settings/settings_main/settings_main.js (right): https://codereview.chromium.org/2111223002/diff/1/chrome/browser/resources/settings/settings_main/settings_main.js#newcode76 chrome/browser/resources/settings/settings_main/settings_main.js:76: url: '', On 2016/06/30 23:40:26, Dan ...
4 years, 5 months ago (2016-07-01 00:59:05 UTC) #7
Dan Beam
lgtm either way https://codereview.chromium.org/2111223002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js File chrome/browser/resources/settings/settings_main/settings_main.js (right): https://codereview.chromium.org/2111223002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js#newcode74 chrome/browser/resources/settings/settings_main/settings_main.js:74: section: '', I assume the section ...
4 years, 5 months ago (2016-07-01 01:11:51 UTC) #8
dschuyler
https://codereview.chromium.org/2111223002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js File chrome/browser/resources/settings/settings_main/settings_main.js (right): https://codereview.chromium.org/2111223002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js#newcode74 chrome/browser/resources/settings/settings_main/settings_main.js:74: section: '', On 2016/07/01 01:11:51, Dan Beam wrote: > ...
4 years, 5 months ago (2016-07-01 22:31:22 UTC) #9
Dan Beam
fyi: I've made a CL to further clarify things regarding routing and the "url" key ...
4 years, 5 months ago (2016-07-01 22:51:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111223002/20001
4 years, 5 months ago (2016-07-01 22:53:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 23:51:05 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 23:51:08 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 23:52:28 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13892b7ca9ef20f61bbd609476a72d4b6fdd3ff9
Cr-Commit-Position: refs/heads/master@{#403565}

Powered by Google App Engine
This is Rietveld 408576698