Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 2111223002: [MD settings] set route on advanced page toggle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: making url optional Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_router.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_router.js b/chrome/browser/resources/settings/settings_page/settings_router.js
index efc38a2c0ee38e6697ac190a35589ba1d8193d8e..ad1dec845befe2b7ca817d6df4359ed86af261c4 100644
--- a/chrome/browser/resources/settings/settings_page/settings_router.js
+++ b/chrome/browser/resources/settings/settings_page/settings_router.js
@@ -4,11 +4,11 @@
/**
* @typedef {{
- * url: string,
+ * dialog: (string|undefined),
* page: string,
* section: string,
* subpage: !Array<string>,
- * dialog: (string|undefined),
+ * url: (string|undefined),
Dan Beam 2016/07/01 01:11:51 can you just remove url from this? and we make a
dschuyler 2016/07/01 22:31:22 Dan and I discussed this offline. Tommy is working
* }}
*/
var SettingsRoute;

Powered by Google App Engine
This is Rietveld 408576698