Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2115133002: MD Settings: add a concept of "Canonical routes", which include URLs (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add a concept of "Canonical routes", which include URLs R=tommycli@chromium.org BUG=608115 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4dbad9e386a6547eff369969b657f4ef3117a859 Cr-Commit-Position: refs/heads/master@{#403568}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_router.js View 4 chunks +36 lines, -29 lines 0 comments Download
M chrome/test/data/webui/settings/router_tests.js View 1 chunk +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2111223002 Patch 20001

Messages

Total messages: 10 (5 generated)
Dan Beam
4 years, 5 months ago (2016-07-01 22:50:20 UTC) #4
tommycli
lgtm
4 years, 5 months ago (2016-07-01 22:57:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115133002/40001
4 years, 5 months ago (2016-07-01 23:52:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-01 23:59:57 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 00:02:33 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4dbad9e386a6547eff369969b657f4ef3117a859
Cr-Commit-Position: refs/heads/master@{#403568}

Powered by Google App Engine
This is Rietveld 408576698