chrome/browser/resources/settings/settings_main/settings_main.js - Issue 2111223002: [MD settings] set route on advanced page toggle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2111223002: [MD settings] set route on advanced page toggle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: making url optional Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_main/settings_main.js

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js

index f9afe10053f9bbe4649a97a3c3b9115cdebe440d..254f2614a20cbdb195c39564ef9c5b7137b97d2e 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.js

+++ b/chrome/browser/resources/settings/settings_main/settings_main.js

@@ -69,6 +69,11 @@ Polymer({

document.addEventListener('toggle-advanced-page', function(e) {

this.showAdvancedPage_ = e.detail;

this.isAdvancedMenuOpen_ = e.detail;

+ this.currentRoute = {

+ page: this.isAdvancedMenuOpen_ ? 'advanced' : 'basic',

+ section: '',

Dan Beam 2016/07/01 01:11:51 I assume the section should be '' and not 'privacy

dschuyler 2016/07/01 22:31:22 I believe so.

+ subpage: [],

+ };

if (this.showAdvancedPage_) {

doWhenReady(

function() {