Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109613004: Remove position info from relocation info. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@turbosourcepos
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove position info from relocation info. R=mstarzinger@chromium.org BUG=v8:5117 Committed: https://crrev.com/d5b89c28cf00f3a791d1a1f5eac05ad7066f60c9 Cr-Commit-Position: refs/heads/master@{#37397}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -570 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm/assembler-arm.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M src/arm64/assembler-arm64.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M src/assembler.h View 10 chunks +9 lines, -78 lines 0 comments Download
M src/assembler.cc View 17 chunks +18 lines, -161 lines 0 comments Download
M src/debug/liveedit.cc View 2 chunks +1 line, -78 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/disassembler.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/assembler-mips.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/perf-jit.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M src/ppc/assembler-ppc.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/s390/assembler-s390.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/s390/assembler-s390.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/x87/assembler-x87.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/x87/assembler-x87.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-reloc-info.cc View 1 chunk +0 lines, -127 lines 0 comments Download

Depends on Patchset:

Issue 2109673003 Patch 20001

Dependent Patchsets:

Issue 2109773004 Patch 1

Messages

Total messages: 15 (7 generated)
Yang
4 years, 5 months ago (2016-06-29 12:03:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109613004/1
4 years, 5 months ago (2016-06-29 12:05:00 UTC) #3
Michael Starzinger
LGTM. I like it. https://codereview.chromium.org/2109613004/diff/1/src/disassembler.cc File src/disassembler.cc (left): https://codereview.chromium.org/2109613004/diff/1/src/disassembler.cc#oldcode173 src/disassembler.cc:173: if (RelocInfo::IsPosition(rmode)) { nit: Would ...
4 years, 5 months ago (2016-06-29 12:17:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/4066) v8_linux_arm64_rel_ng_triggered on ...
4 years, 5 months ago (2016-06-29 12:51:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109613004/20001
4 years, 5 months ago (2016-06-29 12:53:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109613004/40001
4 years, 5 months ago (2016-06-29 13:09:38 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 13:49:30 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 13:50:01 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d5b89c28cf00f3a791d1a1f5eac05ad7066f60c9
Cr-Commit-Position: refs/heads/master@{#37397}

Powered by Google App Engine
This is Rietveld 408576698