Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2109773004: Move RelocInfo::kNoPosition. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@removedead
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move RelocInfo::kNoPosition. R=mstarzinger@chromium.org BUG=v8:5117 Committed: https://crrev.com/141cddc7206a926fe9449a2a47cccb4922ca14e0 Cr-Commit-Position: refs/heads/master@{#37426}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -356 lines) Patch
A buffer View 1 1 chunk +1 line, -0 lines 0 comments Download
A patch View 1 1 chunk +48 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/assembler.h View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M src/ast/ast.h View 5 chunks +7 lines, -7 lines 0 comments Download
M src/ast/scopes.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ast/scopes.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ast/variables.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/compilation-cache.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/source-position.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/lithium-codegen.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/debug/debug.cc View 1 5 chunks +6 lines, -5 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 6 chunks +9 lines, -8 lines 0 comments Download
M src/globals.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M src/parsing/parser.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 2 83 chunks +192 lines, -219 lines 0 comments Download
M src/parsing/parser-base.h View 5 chunks +7 lines, -6 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 12 chunks +31 lines, -36 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/rewriter.cc View 5 chunks +12 lines, -16 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/source-position.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/typing-asm.cc View 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
Yang
4 years, 5 months ago (2016-06-29 13:30:58 UTC) #1
Michael Starzinger
LGTM.
4 years, 5 months ago (2016-06-29 13:38:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109773004/1
4 years, 5 months ago (2016-06-29 13:52:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/18596) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-29 13:55:51 UTC) #6
adamk
lgtm for parsing/ (and excited for the much more sensible name!)
4 years, 5 months ago (2016-06-29 19:18:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109773004/20001
4 years, 5 months ago (2016-06-30 05:43:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18485)
4 years, 5 months ago (2016-06-30 05:47:26 UTC) #13
Benedikt Meurer
LGTM (rubberstamped)
4 years, 5 months ago (2016-06-30 07:13:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109773004/20001
4 years, 5 months ago (2016-06-30 07:31:39 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18491)
4 years, 5 months ago (2016-06-30 07:35:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109773004/40001
4 years, 5 months ago (2016-06-30 08:59:25 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 09:26:39 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 09:29:42 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/141cddc7206a926fe9449a2a47cccb4922ca14e0
Cr-Commit-Position: refs/heads/master@{#37426}

Powered by Google App Engine
This is Rietveld 408576698