Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2109673003: Use source position table in turbofan code. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use source position table in turbofan code. R=bmeurer@chromium.org BUG=v8:5117 Committed: https://crrev.com/447485841249b8d8e372e4aecea68731cf0a8e89 Cr-Commit-Position: refs/heads/master@{#37392}

Patch Set 1 #

Patch Set 2 : drive-by fix for relocation info size reservation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -178 lines) Patch
M src/compiler/code-generator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M src/debug/debug-frames.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M src/frames.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects.cc View 4 chunks +33 lines, -95 lines 0 comments Download
M src/objects-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/profiler/profiler-listener.cc View 1 chunk +17 lines, -45 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
Yang
4 years, 5 months ago (2016-06-29 06:32:55 UTC) #1
Benedikt Meurer
Nice. LGTM.
4 years, 5 months ago (2016-06-29 06:39:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109673003/1
4 years, 5 months ago (2016-06-29 07:20:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/8180) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-29 07:28:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109673003/1
4 years, 5 months ago (2016-06-29 08:29:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/8151) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-29 09:03:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109673003/20001
4 years, 5 months ago (2016-06-29 11:32:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 12:02:48 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 12:04:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/447485841249b8d8e372e4aecea68731cf0a8e89
Cr-Commit-Position: refs/heads/master@{#37392}

Powered by Google App Engine
This is Rietveld 408576698